I just did.
I also would like you to write an exhaustive Javadoc for the API, so on the interface
AttachmentsServiceImpl). That’s where other developers will go to find the documentation as to what this API exactly does.
Also I just finally had a look at the implementation, so
AttachmentsServiceImpl, and it’s great! Reusability Very good.
Now here is what we’ve got, for a given patient:
- a method that can return attachments of a given encounter ;
- a method that can return attachments of a given visit ;
- a method that can return attachments of all encounters.
There is a fourth category of attachments that are not associated with any encounters (and hence any visits either). We need a way to fetch those as well, let’s introduce:
List<Attachment> getIsolatedAttachments(Patient patient, boolean includeRetired);
(We might rename it, I’m not sure yet about the best terminology here.)