Heya everyone ! Continuing my work on the authentication module, Picked up AUT-6 from the Jira board.
When users copy a TOTP code from apps like Google Authenticator, it sometimes pastes with a space in the middle like `123 456` and the verification fails even though the digits are right. added one line to strip whitespace before verification.
PR: https://github.com/openmrs/openmrs-module-authentication/pull/47
Would be grateful if someone reviews it if they get a chance !!
please be patient; the maintainer of that particular repository will definitely attend to you
Excellent observation! I have also continued investigating the auth module, and your fix is very useful indeed. I didn’t think of how copying TOTP codes with whitespaces might lead to validation errors, but that is completely logical. Another great minimal fix! It looks like the right solution to strip any whitespaces prior to validation. Will take a close look at the PR discussion. Also, as I have worked on the O3 frontend and audit areas lately, I am eager to get myself involved into other areas as well.