Failing test by travis within appframe work.

1

According to the ticket i am working on https://issues.openmrs.org/browse/RA-923 ,i am required to make some changes within the app framework.I successfully made the changes and they built well locally but on pushing, i got a failing test!!! I decided to remove all the changes i made and at least add a space within my code,then pushed but still getting the same test failing with even almost no change made since i just added a space.My latest pr for this which also contains the failing test is https://github.com/openmrs/openmrs-module-appframework/pull/35/ I have tried to debug the failing test and it seems it is not an error encountered locally.Could any one be having a clue on solving this travis error??? @dkayiwa @isears @mksd @wyclif @k.joseph

2

Hi @herbert24

This is definitely not your fault. It looks like the travis-ci build tests have been failing for a while now.

I’ve just opened a PR with a fix, but I’m just waiting on feedback from some of the other devs before I merge it in: https://github.com/openmrs/openmrs-module-appframework/pull/36

I’d say for now you should keep working on your ticket and as long as your tests pass locally you should be fine. When the patch gets merged in you can rebase.

3 Likes
3

@mozzy @isears thanks aloot for this

1 Like
4

@isears , ya that looks to be a cool solution. the idea of refreshing the Context >> new AppFrameworkActivator().contextRefreshed() every after test ,seems fine. Thanks.

1 Like
5

@isears that was awesome! :smile:

I have merged it.

1 Like
6

Thanks! Was definitely a tricky bug to track down, haha!

2 Likes
7

@isears @dkayiwa thanks

8

And i love the speed at which you nailed it down @isears ! :smile:

2 Likes