Expanding ConditionValidator

mksd · July 15, 2019, 2:20pm

We’re having a closer look at the condition validations:

openmrs/openmrs-core/blob/a6deb9c564cc91d98e8715aef7df70f52edf0dde/api/src/main/java/org/openmrs/validator/ConditionValidator.java#L47-L52


		if(condition.getCondition() == null){
			errors.rejectValue("condition", "Condition.conditionShouldNotBeNull", "The condition is required");
		}
		if(condition.getClinicalStatus() == null){
			errors.rejectValue("clinicalStatus", "Condition.clinicalStatusShouldNotBeNull", "The clinical status is required");
		}

Shouldn’t we add one that ensures that onset date ≤ end date?

Cc @samuel34

ball · July 15, 2019, 2:37pm

@haripriya was planning to implement onset date ≤ end date

haripriya · July 15, 2019, 2:57pm

@mksd I will make a PR with the required changes

haripriya · July 15, 2019, 7:06pm

Here is my PR

Thank you

haripriya · August 22, 2019, 7:26pm

@mksd Could you please approve this PR . Thank you