yadamz
(Yani Adamz)
August 29, 2017, 1:15am
1
Hello,
I found what is potentially a bug, with OpenMRS. I appreciate your evaluation. This bug shows on our implementation as well as the demo server.
To generate this potential bug please do the following:
This page isn’t working
demo.openmrs.org redirected you too many times.
Try clearing your cookies.
ERR_TOO_MANY_REDIRECTS
I appreciate your advice.
Regards
1 Like
darius
(Darius Jazayeri)
August 29, 2017, 5:50pm
2
You are correct, this is a bug. Can you search on issues.openmrs.org in the
RA project to see if it has been reported already, and if not, create a new
ticket?
(Of course you’re also welcome to submit a fix!)
yadamz
(Yani Adamz)
August 29, 2017, 6:29pm
3
Thanks @darius
Here it is
RA-1408 ERROR: demo.openmrs.org redirected you too many times
Type: Bug
Priority: Must
rakshir
(Rishav Rakshit)
March 6, 2019, 10:38am
4
@yadamz and @darius I see that this hasn’t been worked on in a long time.
I’ve looked into the issue a bit and it seems that when a user is logged in and he tries to visit the demo url in a new tab, it should redirect to https://demo.openmrs.org/openmrs/referenceapplication/home.page but ends up redirecting to https://demo.openmrs.org/openmrs/referenceapplication/login.page instead. A simple fix in the redirection script or the DNS configuration should do the trick, shouldn’t it?
rakshir
(Rishav Rakshit)
March 18, 2019, 7:18am
6
Hi @dkayiwa @darius I’ve worked on the issue and have submitted the pull request here - https://github.com/openmrs/openmrs-module-referenceapplication/pull/51
However I am unable to change the status in JIRA from ‘Waiting for Test’ to ‘Code Review’. Any help on the matter?
I had some other queries on the matter as well. Cause this redirection issue shouldn’t have happened in the first place according to existing code. It would be great if we can have a discussion with people who’ve originally worked on the reference-application module.
dkayiwa
(Daniel Kayiwa)
March 18, 2019, 8:54am
7
You can always initiate a discussion on Talk.
rakshir
(Rishav Rakshit)
March 18, 2019, 9:00am
8
Sure. I’ll do that regarding point number 2.
But how about point 1. I apologize if it sounds like a stupid query, I’m quite new to JIRA.
dkayiwa
(Daniel Kayiwa)
March 18, 2019, 9:10am
9
The Reference Application JIRA project does not have a Code Review state in its workflow.
rakshir
(Rishav Rakshit)
March 18, 2019, 9:25am
10
Oh. So how should the ‘Waiting for Test’ be handled? Also to @ssmusoke
dkayiwa
(Daniel Kayiwa)
March 18, 2019, 9:45am
11
If your pull request ready for testing?
rakshir
(Rishav Rakshit)
March 25, 2019, 9:54am
14
@dkayiwa Hi. As I’ve mentioned, the PR is ready for testing. Should I Create a Zephyr Test? I’m sorry for bothering over the issue It’s just that it effects all ref app versions till now and I think the PR has the resolution. Needed a second eye to validate.
dkayiwa
(Daniel Kayiwa)
March 26, 2019, 2:44pm
15
No need for the Zephyr test. Have you tried to review other peoples’ pull requests?
rakshir
(Rishav Rakshit)
March 26, 2019, 4:16pm
16
You mean Code Reviews? Yes. I’ve done 2 till now. On the following PRs -
I’ve submitted my own PR for this issue. But since Ref App doesn’t have a Code Review stage, its stuck in ‘Waiting for Test’.