Developing the "OCL for OpenMRS" Application


(Cintia Del Rio) #773

Hi @judeatu,

That PR still not what I need.

If you want my early feedback, you could add me as a reviewer, so I could actually add comments before you merge.

  1. You want to move init.sh to a different folder, like root ‘/’ instead of serving it as part of nginx.
  2. You really do not want to copy .env to your docker image. You should be looking for environment variables. I will change the deployment to actually provide them. If in DEV you want to use, it’s up to you, but it’s not something we’ll be doing in prd because it won’t work.
  3. Add ‘nginx -g "daemon off’ at the end of your init script, it’s much simpler to follow

(JUDE INNOCENT ATUHAIRE) #774

Alright @cintiadr, Let me try to implement it in your way will add you for review.


(Bruce Makaaru) #775

Thanks @darius. I’ll be using a workaround in the meantime by Retiring the concept, deleting it’s reference from a Dictionary and adding the new version of the Concept to that Dictionary.


(Rafal Korytkowski) #776

I’m working on a feature to be able to list concepts/mappings in a collection, which can be updated to newer versions and in a subsequent request have them updated.

You are discussing something a bit different, i.e. being able to edit a concept/mapping and at the same time have it updated in a particular collection. You need to handle that from the UI for now.


(Cintia Del Rio) #777

A few more things:

  • I remove those variables from travis, as that wasn’t clearly the problem
  • You can copy the QA docker-compose file to your local test docker-compose file to test it. I’d strongly recommend that.
  • There are instructions in the README to create local docker images to test it.
  • You probably want to move your init.sh file to your docker subfolder
  • Just ignore the .env file. You should use plain environment variables.
  • You don’t want to use init.sh anywhere outside docker. I’d recommend you just set reasonable defaults, and you should be able to override it for development somehow (environment variables or whatever)
  • You want to hardcode the name of the environment variables; you do now want to print all of them.

(JUDE INNOCENT ATUHAIRE) #778

Thanks for this @cintiadr, Let me implement this and will request for you review when am done.


(Andrew Kanter) #779

Can I also check that we are making progress on being about to test a build against the full CIEL dictionary? Do we have a staging server to do this in the works?


(Darius Jazayeri) #780

That doesn’t sound quite right. Why do you have to retire the concept?

When you edit a concept with the API it should automatically create a new concept version, and somehow mark the older one is not being the latest. You do not have to do any further operations on the concept. You do need to do further operations on the collection, i.e. remove the old version and add the new version.

Cool to hear. We’ll want to take advantage of this post-MVP. Is this interactive, i.e. can you choose which ones to update and which ones not to?

@akanter, this is in progress. Specifically the conversation that’s going on between @cintiadr and @judeatu is about doing the back-end plumbing so that the application can be run in multiple environments. (I guess that now it’s hardcoded to the QA environment we’re using.)


(JUDE INNOCENT ATUHAIRE) #781

Hello @cintiadr,

I need some help, about the implementation you want. I have talked to some DevOps engineers at the office and they don’t seem to understand why we are using the init.sh because of the following reasons

  1. Currently, when I use the QA docker-compose file in my local docker-compose file and pass environment variables in the environment I am working in, the docker-compose file will pick them up as required.
  • Basing on this the variables can be got from the deployment environment shell and passed to the app as shown here
  • These variables can then be accessed in src/config/index.js using process.env.
  • The above procedure then eliminates the need for the shell script because the environment variables can be accessed directly and there defaults values that can be used if they are not provided.
  1. The init.sh file only creates a JS file with the environment variables from the .env file put in a Javascript object.
  • This would still be of no use if I don’t have a .env file to pick the environment variables from.

With that said, I am having a hard time trying to implement what you requested so I request for sync with you on HangOut if your available so that you can help me implement this the best way you would want it.

Here is the PR where I tried to implement what you had requested in the first format


(Bruce Makaaru) #782

Hello @darius. I am working on Retire/UnRetire a Concept which granted, acts like Edit, but the “retired” flag has to be set to true/false.


(Cintia Del Rio) #783

Can you rephrase your question? I wasn’t able to understand what’s the problem you are having.


(JUDE INNOCENT ATUHAIRE) #784

@cintiadr, Can we have a sync on HangOut and I take you through the implementation I have?

Here is the link: https://hangouts.google.com/hangouts/_/ytl/0FDsAVWR92CJFb-G2LXfivGbAsJBmSZMgQOkE0N2bzk=?eid=107163098052414183455&hl=en_US

Am already there.


(JUDE INNOCENT ATUHAIRE) #785

The biggest problem am having is passing environment variables using a .sh file without using the .env file. Because the init.sh file I currently have is picking the environment variables that I store in the .env file then create a JS file called env-config.js with the variables in an object as shown below;

window.env = {

OCL_API_HOST: “https://api.qa.openconceptlab.org/”,

TRADITIONAL_OCL_HOST: “https://qa.openconceptlab.org

}

Also when I use the QA docker-compose file in the local test docker-compose file as shown here all I have to do is pass environment variables in the environment using a .env file or an export command and the docker images can access the variables from shell/environment as its stated in the docker documentation


(Rafal Korytkowski) #786

Cool to hear. We’ll want to take advantage of this post-MVP. Is this interactive, i.e. can you choose which ones to update and which ones not to?

It’ll be interactive in the sense that you will be able to provide a list of references to update at once through an API endpoint.


(Cintia Del Rio) #787

I’ve mentioned in this topic a few times, but I’m a volunteer. I do have a full time job (that is not OpenMRS related at all), plus family commitments and I’m in the wrong timezone, I cannot just drop everything to join unscheduled calls for OpenMRS. Please do not expect any answer from me in less than 24h, I do help OpenMRS on my free time.

I don’t think this is how it works. You don’t have a node backend, your server is nginx serving static files. Id doesn’t read any environment variables, as it’s serving only static files. It’s not reading anything from the server.

Instead of using a .env file created during build time, I asked that it read the environment variables. That was all.

Please ignore the .env file, I’m using it, but it’s just confusing you. Just pretend it doesn’t exist, because it should be transparent for your docker container. The environment variables will magically appear there.

I reviewed your PR, and I don’t think that works. You actually undid what I thought it was a solution which was almost done (generating the js file from init.sh during start up), so I’m not sure what to say.


(Rafal Korytkowski) #788

@judeatu, if you still can’t get it right after @cintiadr’s help, let me try to hack one tomorrow.


(JUDE INNOCENT ATUHAIRE) #789

Hi @raff, I believe you should implement it as you said because me trying to implement it may take more time which is slowing down the product release. I appreciate the help provided on trying to implement the task, but me being a beginner in the DevOps work(Docker, Bash). I am having a hard time trying to implement it as required and it may take longer than expected.


(Darius Jazayeri) #790

Okay I see. But please do ensure that you also get things working right for concept edits.

Alternately, if concept edits are already working right then perhaps this code is already implemented and you can leverage it. Or else my understanding of the situation is wrong…


(JUDE INNOCENT ATUHAIRE) #791

Hello Everyone,

Please accept this invitation to our Demo happening tomorrow ( Thursday 21nd March 2019 ) between
5: 00pm - 6 : 00pm EAT .

In this sprint, we worked on the implement feedback provided by stakeholders towards accomplishing the MVP.

Please find more details regarding the demo and the tasks we worked on in this sprint below:-

DEMO DETAILS

Date : 21/03/2019

Time : 5 : 00 PM - 6 : 00 PM (EAT)

Sprint Announcement : OpenMRS OCL Client Sprint 16 Announcement

Video Call Link : Hangouts Link

SPRINT DETAILS

Sprint Wiki : https://wiki.openmrs.org/display/projects/OpenMRS+OCL+Client+Sprint+16

Jira Board : https://issues.openmrs.org/secure/RapidBoard.jspa?projectKey=OCLOMRS&rapidView=186

Github Repository : https://github.com/openmrs/openmrs-ocl-client

OCL live App Link: https://openmrs.qa.openconceptlab.org/

cc @dkayiwa


(Bruce Makaaru) #792

The edit is not working right for concepts, therefore, I’ve created a ticket to fix it. I’ve also added a “before” video to the ticket to illustrate the current issue if you’d like to have a further look at it.

Ticket: OCLOMRS-480