Deprecate PersonNameValidator.validatePersonName (someday)

teleivo · March 28, 2017, 12:18pm

Hello

the PersonNameValidator has a public (non Validator interface method)

PersonNameValidator.validatePersonName

which does the validation and is called internally in the same class by the implementation of Spring’s Validator interface method validate.

I see it being used in the legacyui

github.com

openmrs/openmrs-module-legacyui/blob/master/omod/src/main/java/org/openmrs/web/controller/patient/ShortPatientFormValidator.java#L111


					    new Object[] { personName.getFullName() },
					    personName.getFullName()
					            + " is a duplicate name for the same patient and it's voided. Please restore the existing name "
					            + "instead of creating new name");
				} else {
					errors.reject("Patient.duplicateName", new Object[] { personName.getFullName() },
					    personName.getFullName() + " is a duplicate name for the same patient");
				}
			}
		}
		
		Errors nameErrors = new BindException(personName, "personName");
		new PersonNameValidator().validate(personName, nameErrors);
		
		if (nameErrors.hasErrors()) {
			// pick all the personName errors and bind them to the formObject
			Iterator<ObjectError> it = nameErrors.getAllErrors().iterator();
			Set<String> errorCodesWithNoArguments = new HashSet<String>();
			while (it.hasNext()) {
				ObjectError error = it.next();
				// don't show similar error message multiple times in the view

I am pretty sure this usage can be replaced with a call to the Validator interface method.

If that is the case would you be in favor of deprecating the PersonNameValidator.validatePersonName ? This is not of priority of course, just seems like it would be good to clean this up one day

dkayiwa · March 28, 2017, 12:47pm

Looks like that method should have been private. So am in for the deprecation.

teleivo · June 25, 2017, 10:06am

related ticket which deprecates the method https://issues.openmrs.org/browse/TRUNK-5174 ; already done
future ticket for 3.0.0 release to make it private (and simplify it) https://issues.openmrs.org/browse/TRUNK-5175