Demo Registration App is switching given and family names in confirmation screen (dataCanvas)

craigappl · April 21, 2017, 1:22am

Hi,

I just registered a new patient demo.openmrs.org and noticed that the given and family names aren’t in the right place on the confirmation screen. Name Entry Screen:

Confirmation Screen:

The comma in the name suggests that the order is familyName, givenName, but as you can see, it’s givenName, familyName. It looks like the name is added incorrectly to the dataCanvas in the JavaScript.

Craig

darius · April 21, 2017, 1:41am

Nice catch. Can you create an issue for this in the RA project in JIRA?

craigappl · April 21, 2017, 12:56pm

Thanks @darius, I created RA-1352

wyclif · April 21, 2017, 2:07pm

I propose that we just get rid of the comma and not change the order

ssmusoke · April 21, 2017, 2:27pm

@wyclif The order that the names are displayed should match the order that they are entered - never run into problems with it but the principle has to be enforced

wyclif · April 21, 2017, 2:40pm

I think this is hinting that we probably need to use the name template in the RA, different areas in the world have different name ordering, I’m sure an American would prefer the current order in the summary regardless of the order on the form and in Uganda one would prefer the last name (surname) first on both the form and summary. So how about we use the name template in the RA?

mseaton · April 24, 2017, 11:13am

As far as I can tell from a quick glance at the code, we do use name templates in the registrationapp module for new registrations, editing name details, and displaying a registration summary. However, I think ( and @mogoodrich / @cioan / @darius or others would know better ), the confirmation dialog that is displayed does not use this. This may be a result of how the navigator.js library that is included in uicommons works.

Mike

mogoodrich · April 24, 2017, 9:27pm

Thanks for adding me @mseaton, I wasn’t watching this closely enough!

Mike correct, the issue is that we are not passing in information to the navigator model as to how to render the name… we should pass this in via a “display-template” attribute, and create that template based on the address template.

The display template is set up in the navigator model here:

github.com

openmrs/openmrs-module-uicommons/blob/master/omod/src/main/webapp/resources/scripts/navigator/navigatorModels.js#L299


}, this);
this.questionLegend = this.element.find('legend').first();
var label = $('<span/>').html(this.questionLegend.text());
var spanId = this.questionLegend.attr('id');
if (spanId) {
	label.attr('id', spanId);
}
this.questionLi = $('<li class="question-legend"><i class="icon-ok"></i></li>').append(label);
this.questionLi.appendTo(titleListElem);
this.fieldSeparator = this.element.attr('field-separator') ? this.element.attr('field-separator') : ', ';
var displayTemplate = this.element.attr('display-template');
if (displayTemplate) {
    this.displayTemplate = Handlebars.compile(displayTemplate);
}


var classes = this.element.attr("class");
if(classes) {
    _.each(classes.split(' '), function(klass) {
        QuestionValidators[klass] && this.validators.push(QuestionValidators[klass]);
    }, this);
}

Unfortunately, the display-template is not at all documented nor easy to figure out. I’d need to do a little work to figure it out. I’m willing to work on it, but probably won’t get to it for at least a couple days… if no one else want to take it on,let me know and I’ll pick it up.

Take care, Mark