Coverage/Coveralls issue

(Haripriya Reddy) #1

In one of my PR the coverage check has failed(Coverage decreased (-0.006%) to 59.566%). I am not really sure what that implies and would like to get some help in solving it. Thank you :slight_smile:

(Juliet Wamalwa) #2

Code coverage doesn’t tell you anything about the quality of your tests. It only counts what lines of code are executed during tests and what aren’t. when you do not write code in a ‘testable’ way, you cannot write unit tests for your code, which means, you cannot have 100% coverage.

(Haripriya Reddy) #3

My PR was related to fixing a randomly failing test so i altered the corresponding function where the error was happening . So how far is it accepted to have slightly reduced coverage in this scenario?

(Juliet Wamalwa) #4

Coverage is generated automatically after making the PR.

(Daniel Kayiwa) #5

Did you create a test to confirm that your change fixes the reported problem?

(Haripriya Reddy) #6

The issue was to fix an existing test. I ran the test several times but the issue never occurred and so thought the issue to be fixed