Core: erroneous locale 'kh', what to do now?

mksd · June 15, 2017, 3:30pm

Hi all,

There is a messages_kh.properties in Core (here) meant to be for the Khmer language. But unfortunately the locale ID is erroneous, Khmer would be ‘km_KH’ or at the very least ‘km’ (but not ‘kh’).

(Q.) How do we correct this, is it just a matter of renaming the file to messages_km.properties through a PR or there are other things to do in regards to Transifex… etc?

Cc @ouiliam

darius · June 15, 2017, 9:14pm

Interesting. A bit of googling says that:

Java 8 does not support Khmer: http://www.oracle.com/technetwork/java/javase/java8locales-2095355.html
The 2-letter code is km as you say: http://www.loc.gov/standards/iso639-2/php/langcodes-keyword.php?SearchTerm=khmer&SearchType=ALL

openmrs-core is not translated via transifex, so I think you can just rename the file. (If you’re using the Khmer locale in some implementation you’ll probably be the first to identify any errors that pop up.)

mksd · June 17, 2017, 8:50am

Ok thanks @darius. We may just submit a PR renaming messages_kh.properties to messages_km.properties.

mksrom · October 28, 2022, 7:20am

Fixed! … 5 years later !

JIRA ticket: [TRUNK-6146] Incorrect ISO code for Khmer locale - OpenMRS Issues

dkayiwa · October 28, 2022, 11:40am

Good enough you had not created a ticket for it by then. Otherwise it would be in the graveyard.