Dear all and @sunbiz,
I wrote a new PR for the radiology module
Changes in short:
- it introduces the modules first unit tests!
- uses the hl7api to generate the HL7 order message to create the worklist entries in dcm4chee (and by that fixes some issues)
please have a look at my PR, merge it if you like it or lets discuss it
Looking forward I have a question regarding the design of the class Study:
I want to reduce the uses of OrderService (this module uses the deprecated OrderType which I want to replace in the future)
Study has the member orderId. So whenever I want to get the order of a study I have to use the orderService.getOrder(study.getOrderId())
I am thinking of replacing Study.orderId by Study.Order and creating a simple getter like getOrder() which returns the Study.order
This way I can definitely reduce the uses of OrderService.
Do you have any opinions on that? The openmrs-core does similar thing with Order which has a field of type Patient with a getter for it: getPatient()
Thanks a lot!