@paradise, have you all already implemented the migration code? (I remember discussing this on talk, but maybe it was for diagnoses, not conditions…)
The scenario here is a bit tricky:
- The emrapi module has a “conditions” table, which was intended by its authors to get migrated to core
- but some step in the process got missed, because when we were analyzing TRUNK-5015 we didn’t realize the emrapi table was called conditions.
- therefore we weren’t strict about ensuring that design for TRUNK-5015 is strictly compatible with what was done earlier in emrapi
- However, reviewing this previous thread, I think things are pretty safe: Migrating existing condition data captured via the emrapi module
In other words, yes, do what Wyclif says and use “conditions”, but you’ll need to handle the case where that table might already exist from the emrapi module, so your liquibase changesets and preconditions may look more complicated than usual.
Keep in mind that not everyone running OpenMRS will be running the emrapi module (it’s not included in the basic Platform download, for example), so I think you’re going to need to have two sets of liquibase changesets (or some conditional ones) depending on whether the table exists already or not.