com.fasterxml.jackson.databind.JsonMappingException: Infinite recursion (StackOverflowError)

Development
1

Hey all!

I have created a module trying out some customised get api like below

@RequestMapping("/patient")
@ResponseBody
public ResponseEntity< List<Patient> > search(@RequestParam(value = "mobile", required = false) String mobile) throws ResponseException {
    List<Patient> results = null;
    if (StringUtils.isNotBlank(mobile)) {
        if(!StringUtils.isNumericSpace(mobile)) {
            return new ResponseEntity<>(new ArrayList<>(), HttpStatus.NO_CONTENT);

        }else if( validateNumber(mobile)) {

            results = Context.getPatientService().getAllPatients()
                    .stream()
                    .filter(person -> sameMobile(person.getAttributes(), mobile))
                    .collect(Collectors.toList());

            /**
            List<Patient> allPatients = Context.getPatientService().getAllPatients();
            for(Patient patiient: allPatients){
                if(sameMobile(patiient.getPerson().getAttributes(), mobile)) {
                    results.add(patiient);
                }
            }
            **/
        }
        Boolean resultsExist = results != null && !results.isEmpty();
        if (!resultsExist) {
            return new ResponseEntity<>(new ArrayList<>(), HttpStatus.NO_CONTENT);
        }
        return new ResponseEntity<>(results, HttpStatus.OK);
    }
    return new ResponseEntity<>(new ArrayList<>(), HttpStatus.NO_CONTENT);
}

on executing my api with postman /mymodule/patient?mobile=0708443737, i get an Infinite recursion (StackOverflowError) but if i add this functionality as a search handler in openmrs-module-webservices.rest, it works pretty well.

I am running openmrs instance using the sdk, Reference Application 2.12.2.

@ibacher @dkayiwa what might i be missing here

2

The link you shared for your error log does not seem to work.

3

@dkayiwa, i dont know what my earlier link was invalidated, am sorry for that. i have created another on https://pastebin.com/f4zEumaj

4

ohhhh its broken i guess i have exceeded the characters limit

5

@dkayiwa pastebin is invalidating my log each time i create a new paste so am going to upload it here log.txt (418.4 KB)

6

Are you trying to duplicate the already existing patient end point?

7

I first created the class in openmrs-module-web services.rest until it worked. I migrated the logic in my new module and deleted the handler I had created

8

But the patient end point is already implemented. So my point is, why migrate it to your custom module?

9

i wanted to introduce in another simple functionality of searching by mobile and i thought of keeping the name would give a better hint of the results of the endpoint.

10

Did you follow these guidelines? Adding a Web Service Step by Step Guide for Module Developers - Documentation - OpenMRS Wiki

11

Yes I am using openmrs web services rest version 2.36.0

12

Can you point me to your custom resource class? Just like these ones: openmrs-module-webservices.rest/omod-1.8/src/main/java/org/openmrs/module/webservices/rest/web/v1_0/resource/openmrs1_8 at master · openmrs/openmrs-module-webservices.rest · GitHub

1 Like
13

i didn’t create any resource, for now. So my Module only has one controller Task1RestController.java · GitHub and 2 classes responsible for the module’s activation

14

You need a resource to handle your end point’s domain object.

1 Like
15

hey @dkayiwa creating a corresponding handler resource didn’t work for me, unless there are more tweaks to do with the resource.

16

Which OpenMRS platform versions does your resource support?

17

i am using openmrs version 2.5.0 in my module. I am running my module against Reference application 2.12 which runs core version 2.4.3

18

Take a second look at your resource, and you will understand what am asking for.

19

@dkayiwa i have changed supportedOpenmrsVersions = { "1.8.*" } to supportedOpenmrsVersions = { "1.*", "2.*" } but the error has persisted

20

Commit your entire module on github. And also share the exact full url that you are accessing for this end point, to get the error.