CI build failure for https://issues.openmrs.org/browse/TRUNK-4986

1

Hello

i am working on https://issues.openmrs.org/browse/TRUNK-4986 ticket but i keep getting a travis CI failure each time i make PR https://github.com/openmrs/openmrs-core/pull/2941

@dkayiwa @ruhanga @samuel34

2

That is a huge upgrade that will not just work out of the box. Can you try go down version by version until when you get to the highest version that compiles without errors?

2 Likes
3

let me try that

1 Like
4

@dkayiwa i have tried doing that but it is still failing.

5

Can you list the versions you tried but failed?

6

I have tried all those in the category of 3.0.x, 3.1.x, 3.2.x, 3.3.x, and 3.4.x

7

What errors did you get when you tried the lowest of those versions?

8

For example 3.1.0, i got this https://pastebin.com/fYHPn4GQ abd after trying 3.0.0, i got https://pastebin.com/WhPpDjb8

9

Do you think you can try to get replacements for those failing methods that are needed in the newer versions like 3.0.0?

10

How do I do that?

11

For instance replace Database.getTypeName() with Database.getShortName()

1 Like
12

I have tried this but i am still getting the same error

13

Can you share a pull request of your changes?

14

I have done that

15

Can you also replace LockService.getInstance with LockServiceFactory.getInstance().getLockService

16

i have done that

17

Does it reduce the number of compiler errors?

18

No it doesn’t

19

Do they increase?

20

The number still remains the same