Can't upgrade from OpenMRS 1.10.6 to OpenMRS 1.11.8

mogoodrich · December 20, 2017, 6:59pm

I was just trying to upgrade from 1.10.6 to 1.11.8 and it’s failing because of a checksum validation error during the liquibase update. I checked and it does look like as part of TRUNK-3422 inconsistent change sets were introduced:

github.com

openmrs/openmrs-core/blob/1.10.x/api/src/main/resources/liquibase-update-to-latest.xml#L7768


		<!-- test_order does not have uuid -->
		<!-- user_property does not have uuid -->
		<!-- user_role does not have uuid -->
		<!-- users has not null constraint on uuid -->
		<!-- visit has not null constraint on uuid -->
		<!-- visit_attribute has not null constraint on uuid -->
		<!-- visit_attribute_type has not null constraint on uuid -->
		<!-- visit_type has not null constraint on uuid -->
	</changeSet>


<changeSet id="TRUNK-3422-20160216-1700" author="Wyclif" >
    <preConditions onFail="MARK_RAN">
        <sqlCheck expectedResult="0">
            SELECT count(*) FROM privilege  WHERE privilege='View Visits';
        </sqlCheck>
    </preConditions>
    <comment>Add "View Visits" privilege</comment>
    <insert tableName="privilege">
        <column name="privilege" value="View Visits" />
        <column name="description" value="Able to view visits" />
        <column name="uuid" value="4e7bdbc8-3975-11e6-899a-a4d646d86a8a" />

vs

github.com

openmrs/openmrs-core/blob/1.11.x/api/src/main/resources/liquibase-update-to-latest.xml#L8781


		<update tableName="drug_order">
			<column name="dosing_type" value="org.openmrs.SimpleDosingInstructions"/>
			<where>dosing_type = 'SIMPLE'</where>
		</update>
		<update tableName="drug_order">
			<column name="dosing_type" value="org.openmrs.FreeTextDosingInstructions"/>
			<where>dosing_type = 'FREE_TEXT'</where>
		</update>
	</changeSet>


<changeSet id="TRUNK-3422-20160216-1700" author="Wyclif" >
    <preConditions onFail="MARK_RAN">
        <sqlCheck expectedResult="0">
            SELECT count(*) FROM privilege  WHERE privilege='Get Visits';
        </sqlCheck>
    </preConditions>
    <comment>Add "Get Visits" privilege</comment>
    <insert tableName="privilege">
        <column name="privilege" value="Get Visits" />
        <column name="description" value="Able to get visits" />
        <column name="uuid" value="4e7bdbc8-3975-11e6-899a-a4d646d86a8a" />

Was there a reason for this and has anyone come up with a quick workaround? @mseaton @wyclif

Take care, Mark

dkayiwa · December 31, 2017, 5:04am

I cannot think of anything else other than doing https://wiki.openmrs.org/display/docs/How+to+Modify+a+Bad+Changeset and back port.

mogoodrich · January 2, 2018, 1:44pm

for what it’s worth, our workaround at the end of the day was simply to delete the bad changesets from the changelog. (The changesets all have preconditions so they just get marked as already run on the next run). (I can’t guarantee this will work for all cases, though )

delete ID from liquibasechangelog where ID like 'TRUNK-3422%';

wyclif · January 5, 2018, 7:45pm

When you compare the changesets from the 2 revisions, is there actually any changes between them?

mogoodrich · January 5, 2018, 8:01pm

@wyclif yes, the privilege names were changed from “View” to “Get”

wyclif · January 5, 2018, 8:59pm

I see, the only work around is to delete the changeset from the liquibasechangelog table.

mogoodrich · January 5, 2018, 9:13pm

Yeah, that’s what I figured in the end…

wyclif · January 5, 2018, 9:46pm

I think we need a ticket to fix the changeset to have a valid checksum so that others don’t have to do the same work around.

mogoodrich · January 5, 2018, 10:12pm

Ticket added here: https://issues.openmrs.org/browse/TRUNK-5304

wyclif · January 5, 2018, 10:25pm

Thanks @mogoodrich!