Banda/openHMIS inventory module language issue

Tags: #<Tag:0x00007f56a0519250>

Module: OpenHMIS Inventory Module

Module Version: 3.0.0

System Version: 2.1.4

Reference Application Module: 2.9.0

Issue or Question:

The Inventory reports page seems to have some labels hard coded in Spanish, see screenshot:

If my understanding is correct, the file responsible for this is:

I’m ready to help and create a PR for this, however my skills in java are very low and I’m having problems with building the package. Here are the steps that I did:

  1. Fork the project on github
  2. Clone it locally
  3. Run: mvn clean package

Then I get the following errors:

[ERROR] Failed to execute goal on project openhmis.inventory-api: Could not resolve dependencies for project org.openmrs.module:openhmis.inventory-api:jar:3.0.0: The following artifacts coul
d not be resolved: org.openmrs.module:openhmis.commons-api:jar:4.0.0, org.openmrs.module:openhmis.commons-tests:jar:4.0.0, org.openmrs.module:jasperreport-api:jar:2.0.0: Failure to find org.
openmrs.module:openhmis.commons-api:jar:4.0.0 in was cached in the local repository, resolution will not be reattempted until the update interval of openmrs-repo has elapsed or updates are forced -> [Help 1]

Could you advice on the correct steps to take @ibewes, @whiscard, @insiderish ?

Thanks !

The module has quite a number of dependencies on snapshot versions of other modules. So it requires you to first compile each of those modules with mvn clean install, before you can successfully compile this one. For instance, that error requires you to first compile this one:

Thanks again @dkayiwa for your help, it is very much appreciated!

I could get passed my previous error, by compiling openmrs-module-openhmis.commons and openmrs-module-jasperreports. But one of the test from openmrs-module-openhmis.inventory fails and I get the following error:

Error message
Results :

Failed tests: 
  StockOperationServiceImplTest.calculateReservations_shouldCreateAdditionalTransactionsWhenWhenMultipleDetailsAreNeedToFulfillRequest:749 null

Tests run: 639, Failures: 1, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] OpenHMIS Inventory Module 3.1.0-SNAPSHOT ........... SUCCESS [  0.130 s]
[INFO] OpenHMIS Inventory Module Module API ............... FAILURE [01:34 min]
[INFO] OpenHMIS Inventory Module Module OMOD 1.x .......... SKIPPED
[INFO] OpenHMIS Inventory Module Module OMOD 2.x .......... SKIPPED
[INFO] OpenHMIS Inventory Module Module OMOD 3.1.0-SNAPSHOT SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:34 min
[INFO] Finished at: 2020-02-28T10:26:56Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.14:test (default-test) on project openhmis.inventory-api: There are test failures.
[ERROR] Please refer to /home/nicolas/projects/ELWA/IT/openmrs/modules/openmrs-module-openhmis.inventory/api/target/surefire-reports for the individual test results.

Here is the test results :

You can just ignore that test, for now.

OK thanks, I’ll try to make the changes

Just to follow up, the changes are done and merged upstream:

That is so awesome! Thank you so much @npiaget :slight_smile: