Banda/openHMIS inventory module language issue

npiaget · February 21, 2020, 2:33pm

Module: OpenHMIS Inventory Module

Module Version: 3.0.0

System Version: 2.1.4

Reference Application Module: 2.9.0

Issue or Question:

The Inventory reports page seems to have some labels hard coded in Spanish, see screenshot:

If my understanding is correct, the file responsible for this is:

github.com

banda-health/openmrs-module-openhmis.inventory/blob/develop/omod_2.x/src/main/webapp/pages/reports/entity.gsp#L72


      
                          model: "stockCardReport_item",
                          typeaheadOnSelect: "setStockCardReportItem(\$item)",
                          typeaheadEditable: "true",
                          class: ["form-control report-item"],
                          placeholder: [ui.message('openhmis.inventory.item.enterItemSearch')]
                  ])}
              </li>
          </ul>
          
          
<ul class="table-layout">
              <li><label>${ ui.message("openhmis.inventory.reports.startdate.label")}</label></li>
              <li>
                  <span class="date">
                      ${ ui.includeFragment("uicommons", "field/datetimepicker", [
                              formFieldName: "stockCardReport_beginDate",
                              id: "stockCardReport_beginDate",
                              label: "",
                              useTime: false
                      ])}
                  </span>
              </li>

I’m ready to help and create a PR for this, however my skills in java are very low and I’m having problems with building the package. Here are the steps that I did:

Fork the project on github
Clone it locally
Run: mvn clean package

Then I get the following errors:

[ERROR] Failed to execute goal on project openhmis.inventory-api: Could not resolve dependencies for project org.openmrs.module:openhmis.inventory-api:jar:3.0.0: The following artifacts coul
d not be resolved: org.openmrs.module:openhmis.commons-api:jar:4.0.0, org.openmrs.module:openhmis.commons-tests:jar:4.0.0, org.openmrs.module:jasperreport-api:jar:2.0.0: Failure to find org.
openmrs.module:openhmis.commons-api:jar:4.0.0 in http://mavenrepo.openmrs.org/nexus/content/repositories/public was cached in the local repository, resolution will not be reattempted until the update interval of openmrs-repo has elapsed or updates are forced -> [Help 1]

Could you advice on the correct steps to take @ibewes, @whiscard, @insiderish ?

Thanks !

dkayiwa · February 27, 2020, 11:21pm

The module has quite a number of dependencies on snapshot versions of other modules. So it requires you to first compile each of those modules with mvn clean install, before you can successfully compile this one. For instance, that error requires you to first compile this one: https://github.com/OpenHMIS/openmrs-module-openhmis.commons

npiaget · February 28, 2020, 10:47am

Thanks again @dkayiwa for your help, it is very much appreciated!

I could get passed my previous error, by compiling openmrs-module-openhmis.commons and openmrs-module-jasperreports. But one of the test from openmrs-module-openhmis.inventory fails and I get the following error:

Error message

Results :

Failed tests: 
  StockOperationServiceImplTest.calculateReservations_shouldCreateAdditionalTransactionsWhenWhenMultipleDetailsAreNeedToFulfillRequest:749 null

Tests run: 639, Failures: 1, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] OpenHMIS Inventory Module 3.1.0-SNAPSHOT ........... SUCCESS [  0.130 s]
[INFO] OpenHMIS Inventory Module Module API ............... FAILURE [01:34 min]
[INFO] OpenHMIS Inventory Module Module OMOD 1.x .......... SKIPPED
[INFO] OpenHMIS Inventory Module Module OMOD 2.x .......... SKIPPED
[INFO] OpenHMIS Inventory Module Module OMOD 3.1.0-SNAPSHOT SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:34 min
[INFO] Finished at: 2020-02-28T10:26:56Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.14:test (default-test) on project openhmis.inventory-api: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/nicolas/projects/ELWA/IT/openmrs/modules/openmrs-module-openhmis.inventory/api/target/surefire-reports for the individual test results.
[/details]

Here is the test results : https://paste.centos.org/view/31a673d4

dkayiwa · February 28, 2020, 11:34am

You can just ignore that test, for now.

npiaget · February 28, 2020, 12:09pm

OK thanks, I’ll try to make the changes

npiaget · March 3, 2020, 9:52am

Just to follow up, the changes are done and merged upstream:

dkayiwa · March 3, 2020, 12:16pm

That is so awesome! Thank you so much @npiaget

alagoa · January 29, 2021, 4:34pm

Hello! Is there a chance you can share these inventory omod files with me here? I have tried compiling but without success. And to make things worse I am not a coder. Will be really appreciated as using spanish im my health facility to run reports is a bit confusing and frustrating, Thanks in advance

dkayiwa · January 30, 2021, 8:03pm

Did you try downloading it from here? OpenMRS Add Ons

alagoa · January 30, 2021, 9:57pm

I did, Daniel. I am using the latest OMOD file from there. It was last updated 3 years ago. It still has the spanish language error. I have followed your advice in this post. I was able to successfully compile openhmis common and jasper reports. However, unable to compile inventory due to error as in above post. You had advised the poster to ignore the error and just continue. My question is: Where is the OMOD file stored if the build was a failure? Many thanks in anticipation of your help.

dkayiwa · January 30, 2021, 10:17pm

If the build is successful after compiling with mvn clean package -DskipTests , then you can find the OMOD in the omod\target folder.

alagoa · January 31, 2021, 3:02am

I did with above command. You made it look very easy. Many thanks

indikam · November 26, 2021, 4:56am

Hi, I am also trying to build openhmis-inventory module from source. I have followed all the above and have gotten stuck at the following error

[ERROR] Failed to execute goal on project openhmis.inventory-api: Could not resolve dependencies for project org.openmrs.module:openhmis.inventory-api:jar:3.1.0-SNAPSHOT: Failed to collect dependencies at org.openmrs.module:jasperreport-api:jar:2.1.0-SNAPSHOT: Failed to read artifact descriptor for org.openmrs.module:jasperreport-api:jar:2.1.0-SNAPSHOT: Could not transfer artifact org.openmrs.module:jasperreport-api:pom:2.1.0-SNAPSHOT from/to openmrs-repo-thirdparty (JFrog): Transfer failed for JFrog 409 Conflict → [Help 1]

Any help will be greatly appreciated.

indikam · November 26, 2021, 7:14am

I got this working, Had to build most of the dependencies. Now working on getting the server to boot up with openhmis modules.

indikam · November 29, 2021, 12:26pm

Now everything is working.

One issue I found with some of the openhmis projects was that “DefaultAnnotationHandlerMapping”, was giving an issue with the new spring5 , since spring5 is not supporting DefaultAnnotationHandlerMapping.

I got this resolved by commenting the bean mapping in webModuleApplicationContext.xml.

Since we do not need to specify annotation handlers with spring5, shouldn’t we permanently fix this by removing the bean mapping from webModuleApplicationContext.xml ?

dkayiwa · November 29, 2021, 12:58pm

Why not? Do you want to take a stab at this?

indikam · November 30, 2021, 11:37am

Sure… be happy to.