Adding an OWA to a distro

Development
1

We’re are currently including a couple OWAS (lab workflow and order entry) as part of the PIH EMR distro, and are using a rather ad hoc process for now.

I did see the System Administration OWA listed in the openmrs-distro.properties file for the Ref App and was wandering if there was any support for including an OWA via openmrs-distro.properties? Seeing that entry in the openmrs-distro.properties for the Ref App got my hopes up, but from the following ticket it looks like this may not have been implemented yet?

@raff

Take care, Mark

2

@mogoodrich are you looking for this? https://issues.openmrs.org/browse/SDK-225

3

Thanks @dkayiwa I think that it what I am looking for!

4

So @dkayiwa and @raff I tried the instructions in SDK-225 and it doesn’t appear to be working properly for me…

I manually updated by artifact to bintray and I’m assuming I have the configuration wrong? However, I’m not seeing any warning or errors when I run, so I’m somewhat at a loss of how to debug. Any thoughts?

JFrog Distribution: Get your software to where it needs to be -- ASAP!

Screenshot%20from%202019-09-10%2016-31-40

5

@mogoodrich, your snippet and artifact look good. Could you please share the distro file with variables or the whole project instead of just a screenshot so it can be run? SDK can be debugged as described at https://github.com/openmrs/openmrs-sdk#development

6

Thanks @raff!

Here’s the the distro file:

7

Oh, with the caveat that I haven’t committed my change to add the owa yet…

8

@mogoodrich did you get over this? :slight_smile:

9

Thanks for the reminder @dkayiwa… unfortunately I haven’t gotten a chance to get back to this yet, but it’s still on my radar.

10

Finally getting back to this @dkayiwa… here’s our latest distro file but the SDK still doesn’t seem to be picking up the OWAs, and I haven’t seen anything helpful in the logs yet. Started trying to debug the SDK code today but got distracted, will hopefully get back to this at some point:

Thanks!

11

@mogoodrich is this thread about the fact that sdk:setup would seem to ignore OWAs specified in the openmrs-distro.properties file?

If yes then I think it’s exactly what we’re facing, cc @mddubey.

12

@mksd @mogoodrich @dkayiwa

A few days back I was debugging on similar issue. Below are my observations from that:

  • If we use the SDK:BuildDistro for the SDK it downloads the OWAs and puts them as <name>.owa file in web folder.

  • If we use the SDK:Setup for the SDK it ignores the OWAs completely. Basically if you will check the Setup.java in SDK it has no mention of OWA at all.

13

Thanks @mddubey @mksd!

Basically, if we want to add a new OMOD to the distro, I add the omod to the openmrs-distro.properties.

Then we run a mvn openmrs-sdk:deploy, referencing that distro properties:

… and that omod will be added to the modules folder where that SDK server is set up.

I was hoping a similar thing would happen OWAs (but put them in the owa directory, of course), but that doesn’t seem to work.

Not sure what BuildDistro is? Is that the unlying code that run the deploy command?

Take care, Mark

14

Not sure what BuildDistro is? Is that the unlying code that run the deploy command?

As far as I have understood, for every task, there is a java class in sdk-maven-plugin which gets invoked(e.g. Setup, Deploy, BuildDistro). You might want to debug Deploy.java. This is what I do when I wanted to figure out what all is running in the code.

The debugging has helped since there are so many scenarios and just by looking at code, it was hard to find out which one it is taking.

15

Thanks @mddubey! I started debugging but got pulled away into other things… will hopefully get back to it at some point!

16

@mogoodrich any updates on this track?

17

I think this now works @krishyb , but not 100% sure…