A quick question about testing some modules

andu033 · January 30, 2019, 7:22pm

I started to work at a ticket and i realized that a class (OpenmrsUtil.java) has 2 test files for unit testing. One is named OpenmrsUtilUnitTest and one OpenmrsUtilTest both link to OpenmrsUtil . Is this a mistake/bad practice or it is wanted?

suthagar23 · January 31, 2019, 1:48am

Can you provide links for those two test classes? If it both are checking for similar type of cases, then we need tom merge those.

andu033 · January 31, 2019, 2:27am

Sure. first one and the second one

andu033 · January 31, 2019, 2:29am

Both say in comment Unit tests for {@link OpenmrsUtil}. If you think that we need to merge them i can do that for you and make sure that everything is working.

suthagar23 · January 31, 2019, 3:44am

Can you create a ticket and merge these two tests into one as OpenmrsUtilTest?

andu033 · January 31, 2019, 8:22am

Of course.

dkayiwa · January 31, 2019, 8:35am

Could it be that @teleivo was separating unit (OpenmrsUtilUnitTest ) tests from functional or integration (OpenmrsUtilTest ) tests?

suthagar23 · January 31, 2019, 1:23pm

Ohh, so then can we change the naming of these files according to the type?

teleivo · February 16, 2019, 10:57am

yes, that was the reason I wanted to increase our use of unit tests and not simply add tests to a class that uses a DB (extends BaseContextSensitiveTest). I think we should keep them separate and move more tests over to unit tests.

sharif · November 26, 2019, 5:33am

thanks @teleivo so you want those tests to be tested differently with in each test class