What to do with SpotBugs findings?

[dkayiwa (Daniel Kayiwa)]

Is this of help? Java Conventions - Documentation - OpenMRS Wiki

formalize openmrs-core coding rules and style

Hello friends of clean code I spent some time to understand where the rules from SonarQube came from and if there is any connection to the checkstyle.xml which is in the openmrs-core repository. What I learned: The SonarQube profile OpenMRS contains all rules which lead to the issues on SonarQube. Here https://ci.openmrs.org/sonar/profiles to the right when you click on back up you can download an xml file with the rules. As you can see from the content of the file these are only Fin…

Take SonarQube down or not?

Continuing the discussion from Sonar failures on bamboo!: Sonar checks FindBugs rules and Codacy only checks PMD and Checkstyle rules as discussed here. If we take Sonar down we do not have any tool in place that uses FindBugs and I think we should use one since it can prevent bugs from getting in production. Of course the way Sonar is configured now has not prevented any of these hundreds of critical issues from ending up in the code. So something should change! We can use a maven findbugs …