SessionFactory issue after Hibernate 4 upgrade

I asked on today’s PM call and it wasn’t discussed on last week’s developer forum.

Here is the decision that needs to made…


Do we allow use of the Hibernate Compatibility module?

  • Require OpenMRS Upgrade – modules that use Hibernate 4 should require 2.4+, 1.12+, 1.11.3+, 1.10.2+, or 1.9.9+. We do not use the Hibernate Compatibility module.

  • Allow use of Hibernate Compatibility module – modules that use Hibernate 4 can choose either to require an upgrade or not require an upgrade in older versions of OpenMRS that install the Hibernate Compatibility module.

Currently, on the wiki, we’re giving module authors the option of using the Hibernate Compatibility module. While this is flexibile, it could surprise/confuse implementations if they upgrade a module that requires Hibernate 4 and do not know about the Hibernate Compatibility module.

Proposal

We update this page and stop permitting use of the Hibernate Compatibility module. If we come up with a way to alert implementations before upgrading a module or fail with a clear error that directs the implementer to the solution (i.e., download & install Hibernate Compatibility module), then we could give module authors the additional option of using Hibernate Compatibility.

1 Like