The error isn’t fatal in that it prevents the save operation from happening. Disable the openmrs-contrib-id-sso module – it’s not required for your work, just comment it out.
No, it should not be locked, because we saved it manually. Nothing happens without us intervening. Whatever exists in LDAP should exist in Mongo; I may also want to delete them from LDAP and not migrate them. That’s also something I may want to do. We have probably a few hundred+ accounts like this.
Okay.
But what about default groups? I think, we must add it, before saving to Mongo.
Also, what about features of adding users, and cloning? (I see that there are such feature in the Formage)
Nothing happens automatically. This prevents any issues. You have to look at the groups they’re in in LDAP and just take them, LDAP is the authority here. The only case where we take the default is when we validate a user’s account on their behalf. HOWEVER, as I said, I may delete and not migrate them.
@dmytro.trifonov,
I have some comments:
ReferenceError: results is not defined at /home/rob/openmrs/openmrs-contrib-id/app/user-modules/openmrs-contrib-id-user-management-dashboard/app/lib/Api.js:222:21 at /home/rob/openmrs/openmrs-contrib-id/app/user-modules/openmrs-contrib-id-user-management-dashboard/node_modules/async/lib/async.js:52:16 at done (/home/rob/openmrs/openmrs-contrib-id/app/user-modules/openmrs-contrib-id-user-management-dashboard/node_modules/async/lib/async.js:246:17) at /home/rob/openmrs/openmrs-contrib-id/app/user-modules/openmrs-contrib-id-user-management-dashboard/node_modules/async/lib/async.js:44:16 at Immediate.<anonymous> (/home/rob/openmrs/openmrs-contrib-id/app/user-modules/openmrs-contrib-id-user-management-dashboard/app/lib/Api.js:206:11) at Immediate._onImmediate (/home/rob/openmrs/openmrs-contrib-id/node_modules/mquery/lib/utils.js:137:16) at tryOnImmediate (timers.js:534:15) at processImmediate [as _immediateCallback] (timers.js:514:5)
[2016-08-21 01:37:50.970] [INFO] console - [TypeError: userMongo.save is not a function] TypeError: userMongo.save is not a function at Promise.<anonymous> (/home/rob/openmrs/openmrs-contrib-id/app/user-modules/openmrs-contrib-id-user-management-dashboard/app/lib/Api.js:159:23) at Promise.<anonymous> (/home/rob/openmrs/openmrs-contrib-id/node_modules/mpromise/lib/promise.js:177:8) at emitOne (events.js:90:13) at Promise.emit (events.js:182:7) at Promise.emit (/home/rob/openmrs/openmrs-contrib-id/node_modules/mpromise/lib/promise.js:84:38) at Promise.fulfill (/home/rob/openmrs/openmrs-contrib-id/node_modules/mpromise/lib/promise.js:97:20) at Immediate.cb (/home/rob/openmrs/openmrs-contrib-id/node_modules/mongoose/lib/query.js:1153:30) at Immediate._onImmediate (/home/rob/openmrs/openmrs-contrib-id/node_modules/mquery/lib/utils.js:137:16) at tryOnImmediate (timers.js:534:15) at processImmediate [as _immediateCallback] (timers.js:514:5)
http://react-toolbox.com/#/components/table
We can set only column types (in the model)What about next features, I worked on now:
Also, did you saw my PR? I fixed group list for ‘getAllUsers’ from ldap
What features I must be focus on before deadline? Thanks
Er – sorry about that – that is really sucky 
That works for me,it should be easy as a field swap.
I want to have a button “Delete X users” if >1 user is selected – I will never edit users in bulk
Nope, not that I can see – I did a git pull before I ran this.
Yeah – hide it for now.
Only one – yes. Removal of the user will handle both – If I toggle one, the other should be disabled.
That’s the point. You trigger the email being sent for them for them to reset the email.
If these are workable, in two days – sure BUT first fix the bugs/issues I mentioned above.
I will look.
At this stage, you have 2 days, so all the bugs ironed out in existing features.
I like it. Can we change the text by the sliders? There has to be a way…
What text do you mean?
inLDAP, InMongo – those – let’s make it OpenLDAP, MongoDB
Okay 
Regarding other notes: I’ve already done: added ‘locked’ column to the list of default columns, and also added button to set an email from emailList as primaryEmails.
Can you make a ‘git pull’ now, and check, if “remove user” option works for you? If not, please send me actual error log, because on my machine everything works fine. Thanks
if you’ll select multiple users, and click ‘delete’ now - it will delete all of them
@dmytro.trifonov, Removing user does not work:
[2016-08-21 19:28:58.556] [DEBUG] ldap - check validity of username undefined [2016-08-21 19:28:58.564] [DEBUG] ldap - ldap search ended with status: 0 [2016-08-21 19:28:58.565] [DEBUG] ldap - user: undefined not found [2016-08-21 19:28:58.566] [INFO] console - [ReferenceError: results is not defined] ReferenceError: results is not defined at /home/rob/openmrs/openmrs-contrib-id/app/user-modules/openmrs-contrib-id-user-management-dashboard/app/lib/Api.js:222:21 at /home/rob/openmrs/openmrs-contrib-id/app/user-modules/openmrs-contrib-id-user-management-dashboard/node_modules/async/lib/async.js:52:16 at done (/home/rob/openmrs/openmrs-contrib-id/app/user-modules/openmrs-contrib-id-user-management-dashboard/node_modules/async/lib/async.js:246:17) at /home/rob/openmrs/openmrs-contrib-id/app/user-modules/openmrs-contrib-id-user-management-dashboard/node_modules/async/lib/async.js:44:16 at /home/rob/openmrs/openmrs-contrib-id/app/user-modules/openmrs-contrib-id-user-management-dashboard/app/lib/Api.js:211:11 at check (/home/rob/openmrs/openmrs-contrib-id/app/ldap.js:400:16) at fn (/home/rob/openmrs/openmrs-contrib-id/node_modules/async/lib/async.js:582:34) at Immediate._onImmediate (/home/rob/openmrs/openmrs-contrib-id/node_modules/async/lib/async.js:498:34) at tryOnImmediate (timers.js:534:15) at processImmediate [as _immediateCallback] (timers.js:514:5)
At a bare minimum – there needs to be error handling – and me to be able to do basic user management 
if you can’t reach the API – you need to tell me that. This is completely doable – come on you’re so close!
Thanks for your feedback, just fixed that!
You have until 17:00 UTC Tomorrow, 23 August to submit both your code sample and your evaluation of me to Google via the Summer of Code site.
Up until then keep working, at this stage, just iron out the bugs. Reset Password would be REALLY nice but not immediately necessary. Don’t worry about documentation, for now. If you get stuck, let me know, but responses and ability to help will be limited. Be forewarned however, I will be traveling for the better part of the day Tomorrow (Tuesday, 23 Aug).
One thing that would be nice is if you made a video walkthrough – even if it’s not useable by the community at large, just showing what you this summer.
It was a great summer and I hope you had fun!
Okay, today I will make some improvements, and submit code sample.
yep, this summer was great! I got a lot of knew knowledge about react, webpack, ES6/ES7, and hope, that my work will be useful for community! I have a lot of ideas for the User Dashboard, and will continue my work on it
Keep working until 1630 UTC tomorrow. This gives me the chance to point out bugs as I see them.
@dmytro.trifonov, Some final notes:
Y or N.
MongoDB deletes from BOTH – this is how it’s supposed to be.That said – you have enough of a prototype - it kinda works with a few bugs. Great work.
Thanks, Robert!
Yep, I know about this… it’s also about other "Boolean’ fields (inLDAP, inMongo). I don’t know the reason for now, but when we set Boolean ‘true’ to ‘false’ - this change doesn’t appear in the grid. But changing ‘false’ to ‘true’ works fine.
Ok, and it may fix previous bug :)[quote=“r0bby, post:306, topic:6292”] 4. Deleting a user from MongoDB – also deletes them from LDAP. [/quote]
Hmm… strange, because I set flag ‘inLDAP’ in the user to ‘false’ before deleting, so it must save ldap entry. Leave it as is?
Regarding confirm message - I will add it
Okay, you propose to remove feature of bulk editing? I made it, because I thought that it will be useful to lock/unlock multiple entries by one action, or set permissions (using groups).
Also, I propose to start some versioning of our project. When I fix all above bugs, I’ll set tag ‘v0.2’ on the repo, (v0.1 was the version with UI prototype ), and then I will continue make improvements on the road to v1.0. It will be stability improvements (such as good error handling, and, which is very important, validations), and also support of new features (reset password, create/clone users, etc). We may discuss our roadmap later.
Weird. Not a deal breaker – If we need to go a different route, we will. This is a first pass.
It will rarely ever happen. Maybe have both Edit/Delete? I like less clicks
Yes, we can completely do that – whatever you have after 1700 UTC – is v0.1, tag it. I’m going to propose that your work be moved to the OpenMRS Github Org. This isn’t ready to be used in production yet. Let’s make time to iron out a roadmap – I’ll make a new thread soonish.
One other thing – Change the headings:
Username, First Name, Last Name, Primary E-mail, LDAP, Mongo, Locked are the headers I envision. Spaces – it IS possible to have spaces in the headings. Again, great work! A few bugs but things work almost as I envisioned. I will check in a few hours again – but won’t be able to do a review – I will before I do my final eval – and will give feedback there to you. I’m not sure if I’m allowed to say if you’d pass/fail – but I’ve been upfront all summer so you should have an intuition.
