orderentryui - provider is undefined in order-entry.js

darius · November 5, 2015, 4:02pm

@mksd , I think the confusion may be what Mike mentioned in his first reply to you (but I will expand, because it’s not obvious).

Prior to OpenMRS 1.9, you indicated that a user was a provider by giving the “Provider” Role to that User. This is what you are showing in the REST result. However things changed in OpenMRS 1.9, and the code no longer looks for this.

Since OpenMRS 1.9 there is a Provider domain object, which is not directly linked to User. Rather a Person can have 0…n User accounts, and 0…n Provider accounts. The Reference Application does some simple logic that you can see here:

github.com

openmrs/openmrs-module-appui/blob/master/omod/src/main/java/org/openmrs/module/appui/UiSessionContext.java#L61


this.session = request.getSession();
Integer locationId = (Integer) session.getAttribute(LOCATION_SESSION_ATTRIBUTE);
if (locationId != null) {
    this.setSessionLocationId(locationId);
    sessionLocation = locationService.getLocation(locationId);
}
userContext = Context.getUserContext();
if (userContext != null && userContext.getAuthenticatedUser() != null) {
    User currentUser = userContext.getAuthenticatedUser();
    Collection<Provider> providers;
    try {
        Context.addProxyPrivilege(PrivilegeConstants.GET_PROVIDERS);
        providers = providerService.getProvidersByPerson(currentUser.getPerson(), false);
    } finally {
        Context.removeProxyPrivilege(PrivilegeConstants.GET_PROVIDERS);
    }
    if (providers.size() > 1) {
        throw new IllegalStateException("Can't handle users with multiple provider accounts");
    } else if (providers.size() == 1) {
        currentProvider = providers.iterator().next();
    }

You need to make sure that the currently-logged in user has a Provider account, i.e. that the user’s person has a matching row in the provider table.

In the REST response you should be seeing a “currentProvider” property, as generated here:

github.com

openmrs/openmrs-module-appui/blob/master/omod/src/main/java/org/openmrs/module/appui/rest/SessionController.java#L44


private LocationService locationService;


@Autowired
private ProviderService providerService;


@RequestMapping(method = RequestMethod.GET)
@ResponseBody
public Object get(HttpServletRequest request, HttpServletResponse response){
    RequestContext requestContext = RestUtil.getRequestContext(request, response);
    Representation rep = requestContext.getRepresentation();


    UiSessionContext uiSessionContext = new UiSessionContext(locationService, providerService, request);
    SimpleObject ret = new SimpleObject()
            .add("authenticated", uiSessionContext.isAuthenticated())
            .add("locale", uiSessionContext.getLocale().toString())
            .add("currentProvider", ConversionUtil.convertToRepresentation(uiSessionContext.getCurrentProvider(), rep))
            .add("sessionLocation", ConversionUtil.convertToRepresentation(uiSessionContext.getSessionLocation(), rep))
            .add("user", ConversionUtil.convertToRepresentation(uiSessionContext.getCurrentUser(), rep));
    return ret;
}

Does this make sense?

*** = I notice one possible bug: the UiSessionContext constructor code uses the VIEW_PROVIDERS proxy privilege, which could be buggy if the appui module was compiled against OpenMRS < 1.11, but is run against 1.11+ (however looking further, this should be okay, since appui inherits its versions from the distro, so it should be building against the same openmrs-core version).