Integration with OpenEMPI

[mseaton (Mike Seaton)]

@wyclif I was posing more of a hypothetical, though realistic scenario.

[wyclif (Wyclif Luyima)]

Sorry I got everything mixed up, I thought that @shaoyuan was actually running into that issue

[shaoyuan (Shao Yuan Chew Chia)]

Hi All!

I have submitted three pull requests, hope that you guys can take a look and provide some feedback

Integrating MPI Functionality

Integrating MPI Functionality

Integrating MPI Functionality

The Registration App Module is failing build on travis, however it is working fine when I mvn clean install on my local machine. @mogoodrich and I suspect that it is because it requires the new registrationcore version. Thus we need to approve and merge Registration Core first, and then the build pipeline will publish the updated snapshot to the OpenMRS maven repo, and then the Registration App build should pass (assuming there aren’t any other issues… )

I welcome all feedback/critiques of the code! And will try my best to improve it!

• Shao Yuan

[dkayiwa (Daniel Kayiwa)]

I tried to look at one of the pull requests https://github.com/openmrs/openmrs-module-registrationcore/pull/20, but found it too big. Is there any way of breaking down this work in smaller bits that are easier to review and merge?

[wyclif (Wyclif Luyima)]

I agree with Daniel, the PR is too long, it’s tough to review, you could have broken the tasks into smaller chunks so that the PRs are smaller.

[wyclif (Wyclif Luyima)]

This is great work @shaoyuan!

I think I agree with Daniel, one of the PRs is somehow too long, it’s kind of tough to review, you could have broken the tasks into smaller chunks so that the PRs are smaller.

Wyclif

[mseaton (Mike Seaton)]

@wyclif and @dkayiwa - I had the same thought and it would definitely be easier. But @shaoyuan was mainly just trying to merge in this branch that was created by another group, so this is a bit out of his hands…

[dkayiwa (Daniel Kayiwa)]

@mseaton are all these massive changes simply about integrating the MPI functionality, but nothing more?

[mseaton (Mike Seaton)]

@dkayiwa - yes as far as I know. I defer to @shaoyuan

[shaoyuan (Shao Yuan Chew Chia)]

@dkayiwa yes, its just the MPI functionality

[shaoyuan (Shao Yuan Chew Chia)]

Hi @craigappl,

After some discussions with @mseaton, @mogoodrich and @jiahaochua, during which we talked about the possibility of using an asynchronous central messaging queue for the PIX patient creation and updating in the MPI, I was reading through your earlier comments on this thread and saw that you had begun discussions about it. I was wondering if you could shed some light on a couple of areas:

1. What were the reasons behind the decision to do PIX synchronously instead of asynchronously via the queue

@craigappl

We aim to develop synchronous calls to the MPI using PIX and PDQ.

2. To what extent were these workflows developed? and how do they work? because my understanding/experience with the code is that even failures not caused by failed internet connection are retried, and they will never work, so they are just retried forever, furthermore there is no way to delete these failed messages from the table in the Outgoing Message Exceptions module.

@craigappl

Sample failures:

There is a failure in the internet connection PDQ - Log the failure as INFO PIX - Store the failed document in a central location so it can be audited, reviewed, and accessed by Mirth for a retry

The MPI Returns an invalid message type in the ACK ERROR section PDQ - There is likely an issue that needs to be addressed by an administrator. We need to expose these to an admin. PIX - There could be a number of issues that each need a response to follow a particular set of business logic

@craigappl

• We are in the process of identifying workflows for each type of failed message.

3. Was this discussion continued? and what was the conclusion/ could you link me to it?

@craigappl

Start a thread discussing the different architecture approaches of atom feed sync vs a local queue.

@pgesek do you have any comments/information on these questions? It would be really helpful to have your input as well!

Thank you all!

[leqela (Tiisetso Leqela)]

Hello Wyclef I am getting some bugs when trying to access the openEMPI. I am using ubuntu 16.04 LTS as my operating system platform.I have install openEMPI version 3.5.0.actually is some issues with my jvm and tomcat issues.