To not rely on LegacyUI, I’ve copied AdministrationSectionExt from openmrs-module-legacyui/AdministrationSectionExt.java at master · openmrs/openmrs-module-legacyui · GitHub into omod-common module. I’m wondering if that’s a good solution though. If I didn’t include this class, the SwaggerSpecificationCreatorTest test would fail with NoClassDefFoundError. What do you think I should do with this? Fix the test and not include the Ext class or just leave it like right now?
Another solution to this problem would be to include AdministrationSectionExt class in openmrs-core project.
After investigating, it turned out that the UserResource already supports such a filter, and you would only need to append includeAll=true parameter to retrieve all users, including disabled ones.
It involves exposing PatientService.getDuplicatePatientsByAttributes() through REST. Should I just add this functionality to doSearch method in PatientResource1_8 or should I create new resource/controller ?
The last one is blocked by another issue:
TRUNK-6010
We’ve found that there were more issues with HibernatePatientDAO.getDuplicatePatientsByAttributes than initially thought. However, I’ve already submitted my PR with a fix here: https://github.com/openmrs/openmrs-core/pull/3814
In the upcoming week, I’m planning to close any currently reviewed/in progress tasks and move to RESTWS-829 which will be quite significant.
We’ve finally merged an issue TRUNK-6010 which blocked RESTWS-842. However, we couldn’t add appropriate tests to it in REST-WS module, as it doesn’t have access to the newest Core module (2.5 SNAPSHOT). That’s why we’ve decided to ignore those tests for now and unignore them after 2.5 version release.
There is 1 task currently undergoing a code review:
A quick note about RESTWS-829, initially I thought this task would involve coding. However, after investigating for a bit, it turned out that there are already REST Resources that fulfill the functionality of corresponding Legacy UI pages. That’s why I will only need to prepare the documentation, but it’s going to be significant, as I will have to document at least 6 resources
In the upcoming week, I’m going to work on the two issues above as they are pretty significant in the volume of work needed.
In the upcoming week, I’m going to work on the two issues above. One of them should be fully about documentation and the other should involve creating new custom REST resource. Finally, I’m getting some bigger coding tasks. I’m glad because I was doing a lot of documentation lately
In the upcoming week, I’m going to work on the two issues above. Both of them will involve creating new REST resources, as well as adding some documentation to them.
In the last week, I’ve been able to close all of my tasks. We’ve also found 3 more endpoints that I forgot to implement, so they were my main goal for this week.
In the upcoming week, I’m going to work on my final evaluation. I will have to create a video presentation about my project and a document describing all my tasks. Also, I will prepare a final talk post and update the OpenMRS wiki page about my project.
Please have a look at my draft final evaluation. I still have to record a video presentation so I will send it to you later. Also, I would like to get some tips from you on how to demonstrate my work as it was mainly REST APIs and their documentation so there’s not much visual content that I can present
@dkayiwa I’ve attempted to record a video only about the resources that I’ve modified (there are 12 of them), but I don’t think I’m going to fit in those 5 minutes, even if I’m only showing the REST calls. Can I exceed that limit, for example, to under 10 minutes?
