piumal1999
(Piumal Rathnayake)
June 23, 2021, 7:55pm
21
2021-06-22T18:30:00Z Update
The Pull Request for the database change was merged today by @jayasanka .
I sent the Pull request for initiating the location mapping UI.
openmrs:master
← Piumal1999:DCM-47
opened 07:25PM - 22 Jun 21 UTC
## The issue I worked on
See [https://issues.openmrs.org/browse/DCM-47](https:/… /issues.openmrs.org/browse/DCM-47)
## Description of what I changed:
Created the User interface of location mapping
This UI displays the mapped location-orgUnits which are saved in the database
Note- Saving/Updating feature will be added under a new JIRA issue
<img width="1678" alt="Screenshot 2021-06-23 at 00 32 15" src="https://user-images.githubusercontent.com/27498587/122985070-5b5b7e80-d3bb-11eb-8fcc-29abb98c1ad6.png">
Please review and merge.
Also, I tried adding ‘automated location mapping’ to the automation UI. And it was kind of successful. Maybe it’s not the optimum way. When an automated mapping is running, it fetches the available organisation unit of the mapped dataset and push data to those org Units from the respective locations taken from the database. Here’s a small preview.
1 Like
piumal1999
(Piumal Rathnayake)
June 26, 2021, 1:01pm
22
Weekly Meeting (Week 3) - 2021-06-25T18:30:00Z
Attendees:
@piumal1999 @akshika47
Updates:
@akshika47 got access to the DHIS Connector module Github repository
Created JIRA issues for adding support for 8 remaining period types in Automation
Created JIRA issue for initiating location mapping UI
Created JIRA issue for adding save/update functionality to location mapping UI
Almost completed the task.
Need to merge previous pull requests before creating the PR
@piumal1999 was able to optimize the location mapping saving functionality
Can add it from the next Pull request
@piumal1999 was able to test the automation with the Automatic location mapping feature locally.
Added a preview in a previous Talk comment
Need more testing
Found the reason for the 500 Internal server error of using APIs of Reporting Rest module.
Next Steps:
cc: @jayasanka @k.joseph
1 Like
piumal1999
(Piumal Rathnayake)
June 30, 2021, 6:21pm
23
2021-06-29T18:30:00Z Update
These Pull requests were merged by @jayasanka yesterday
openmrs:master
← Piumal1999:DCM-47
opened 07:25PM - 22 Jun 21 UTC
## The issue I worked on
See [https://issues.openmrs.org/browse/DCM-47](https:/… /issues.openmrs.org/browse/DCM-47)
## Description of what I changed:
Created the User interface of location mapping
This UI displays the mapped location-orgUnits which are saved in the database
Note- Saving/Updating feature will be added under a new JIRA issue
<img width="1678" alt="Screenshot 2021-06-23 at 00 32 15" src="https://user-images.githubusercontent.com/27498587/122985070-5b5b7e80-d3bb-11eb-8fcc-29abb98c1ad6.png">
openmrs:master
← Piumal1999:DCM-41
opened 08:15PM - 25 Jun 21 UTC
## The issue I worked on
See [https://issues.openmrs.org/browse/DCM-41](https:/… /issues.openmrs.org/browse/DCM-41)
## Description of what I changed:
Added the BiMonthly period support to automation
openmrs:master
← Piumal1999:DCM-40
opened 09:22AM - 26 Jun 21 UTC
## The issue I worked on
See [https://issues.openmrs.org/browse/DCM-40](https:/… /issues.openmrs.org/browse/DCM-40)
## Description of what I changed:
Added the BiWeekly period support to automation
I sent the pull request for save/update feature on location mappings today.
openmrs:master
← Piumal1999:DCM-48
opened 07:07AM - 30 Jun 21 UTC
## The issue I worked on
See [https://issues.openmrs.org/browse/DCM-48](https:/… /issues.openmrs.org/browse/DCM-48)
## Description of what I changed:
Add Saving/Updating feature to the location mapping page
![image](https://user-images.githubusercontent.com/27498587/123916990-e7633c80-d99f-11eb-838f-fe2a100b929c.png)
Also, I was able to fix the 500 Internal Server error caused in Reporting Rest Module! I’ll create an issue for that and send the pull request.
Thank you @dkayiwa for helping. I tested this by updating the reporting rest module locally and it works!!!
I just removed the class property.
[image]
Shall I create an issue on JIRA and send a pull request to fix this?
Now I can work on creating run reports UI with automated location mapping
cc: @akshika47 @k.joseph @jayasanka
2 Likes
piumal1999
(Piumal Rathnayake)
July 3, 2021, 1:22pm
25
Weekly Update - Week 4
From 2021-06-26T18:30:00Z to 2021-07-02T18:30:00Z
Updates:
Fixed the error occurred in reporting rest module
Sent the Pull Request and it was merged
Sent the Pull Request for save/update location mappings
Created issue for Updating run reports UI to work with location mappings
Tested Upgraded Run Reports UI locally
Send data function is completed
Download DXF json functionality is also completed
Download ADX functionality is not completed yet.
It throws a Class Cast Exception
Request processing failed; nested exception is java.lang.ClassCastException: javax.xml.namespace.QName cannot be cast to javax.xml.namespace.QName
Need to find the reason for the error
Tested the Upgraded Automation UI with location mappings locally
.
Next steps:
Create issues for remaining location mapping tasks
Upgrade the Run Reports UI and Automation UI to work with the location mapping feature
Recheck the scheduling functionality
Start working on Role Based Access Control System
cc: @akshika47 @k.joseph @jayasanka
1 Like
piumal1999
(Piumal Rathnayake)
July 3, 2021, 3:59pm
26
Here’s a small preview of upgraded run reports UI.
piumal1999
(Piumal Rathnayake)
July 4, 2021, 4:11pm
27
2021-07-03T18:30:00Z Update
The Pull request for location mapping UI was merged yesterday. Thank you @jayasanka and @akshika47 for reviewing and merging.
I found that the ADX download option (in Run Reports UI) is not working in the current version of the DHIS Connector Module. It throws a 500 Internal server error.
I created 2 new pull requests for Upgrading run reports functionality and automation functionality. Still, the Pull requests are in draft mode. I need to do recheck it before making it ready for review.
And the JIRA issues are still under review and need to be marked as ‘Ready for Work’.
https://issues.openmrs.org/projects/DCM/issues/DCM-49
https://issues.openmrs.org/projects/DCM/issues/DCM-50
@akshika47 @jayasanka Could you please check it and update the issue state.
1 Like
piumal1999
(Piumal Rathnayake)
July 5, 2021, 7:38pm
28
2021-07-04T18:30:00Z Update
Added unit tests to the previous Pull request. Now it is ready for review.
openmrs:master
← Piumal1999:DCM-49
opened 08:40PM - 03 Jul 21 UTC
## The issue I worked on
See [https://issues.openmrs.org/browse/DCM-49](https:/… /issues.openmrs.org/browse/DCM-49)
## Description of what I changed:
Upgraded the Run Reports Functionality to work with automated location mappings
![ezgif com-gif-maker (6)](https://user-images.githubusercontent.com/27498587/124366345-ca16c280-dc6c-11eb-95c7-ce8b2ae7c9c8.gif)
Also sent a Pull Request for Supporting Weekly Sunday Period Type
openmrs:master
← Piumal1999:DCM-39
opened 07:31PM - 05 Jul 21 UTC
## The issue I worked on
See [https://issues.openmrs.org/browse/DCM-39](https:/… /issues.openmrs.org/browse/DCM-39)
## Description of what I changed:
Added Weekly sunday period support to automation
Fixed a bug in weekly period support
Please review and merge
piumal1999
(Piumal Rathnayake)
July 10, 2021, 9:10pm
29
Weekly Update - Week 4
From 2021-07-03T18:30:00Z to 2021-07-09T18:30:00Z
Updates:
Upgraded the Run Reports UI and Sent the pull request. (A preview GSoC 2021: Improving Functionalities of DHIS Connector Module - Project Updates - #26 by piumal1999 )
Added the unit tests and updated the pull request
Sent the draft pull request for Upgrading the Automation UI. But it can’t be merged due to the conflicts. Need to merge the previous pull request ( DCM-49: Add automated location mapping for Run Reports UI ) before merging it.
The pull request for Supporting Weekly Sunday period type was merged
Also fixed a bug in Weekly period type with the same Pull request
So now the automation UI supports the Weekly Sunday period type
Also I sent 2 more Pull requests for more period types
Weekly Wednesday DCM-44 - Merged
Weekly Thursday DCM-45
I can send the pull request for Weekly Saturday period type as soon as the previous pull request is merged
Started working on the Role Based Access Control System
Found some resources for the task.
Tested the module pages by adding privileges
I’ll create another thread for the updates of this feature
Next week:
Finalizing the roles and privileges (A new thread will be used)
And Try to Send the pull request for creating privileges
Completing the Run Reports UI (Reviewing and merging)
Completing the Automation UI
Add the remaining period type supports for automation
cc: @akshika47 @k.joseph @jayasanka
piumal1999
(Piumal Rathnayake)
July 15, 2021, 6:51pm
31
piumal1999:
Also, I tried adding ‘automated location mapping’ to the automation UI. When an automated mapping is running, it fetches the available organisation unit of the mapped dataset and push data to those org Units from the respective locations taken from the database. Here’s a small preview.
This is the automation UI that I have designed now. But I noticed that with this design, users can’t see which locations-orgunit mappings are available for the selected mapping.
In the run reports UI, it automatically shows the available location-orgUnit sets but here it doesn’t.
So do we need to show the available location-orgUnit sets in here also? Or is that not needed
cc: @jayasanka
piumal1999
(Piumal Rathnayake)
July 17, 2021, 8:08pm
32
Weekly Meeting (Week 5) - 2021-07-16T18:30:00Z
Attendees: @akshika47 @piumal1999
Updates:
@piumal1999 started a new thread for Finalize the User Access Control feature
Proposed Privileges for DHIS Connector module:
View Connection - Viewing DHIS2 Connection
Manage Connection - Edit DHIS2 Connection
View Location Mappings - View location-orgunit mappings
Manage Location Mappings - Edit/Delete location-orgunit mappings
View Automation - View scheduled mappings
Run Automation - Run scheduled mappings
Manage Automation - Add/Edit/Delete scheduled mappings
Run Reports - Base privilege for running the reports
Run failed data - Base privilege for pushing the failed data
Manage Mappings - Create/Edit Mappings
Import and Export - Import and export mappings and DHIS2 API
Next week:
Create the privileges for module
Continue working on the Access control system
Completing the Run Reports UI (Merging the Pull request)
Completing the Automation UI
1 Like
piumal1999
(Piumal Rathnayake)
July 23, 2021, 12:59pm
33
Hi @jayasanka @akshika47 , I was able to upgrade the Automation(Scheduling) functionality of DHIS Connector module integrating it with Automated Location Mapping, so the users don’t have to choose the locations and org. units manually. Here’s a small preview.
JIRA Link:
https://issues.openmrs.org/browse/DCM-50?filter=-1
PR Link:
openmrs:master
← Piumal1999:DCM-50
opened 09:22PM - 03 Jul 21 UTC
## The issue I worked on
See [https://issues.openmrs.org/browse/DCM-50](https:/… /issues.openmrs.org/browse/DCM-50)
## Description of what I changed:
Upgraded the Automation(Scheduling) Functionality to work with automated location mappings
## Preview
https://vimeo.com/578453879
Please review and merge.
piumal1999
(Piumal Rathnayake)
July 23, 2021, 1:28pm
34
Unable to update data model using liquibase.xml - Module DHIS Connector
With the automated location mapping feature, the database of module will be changed a bit. Unwanted columns of both tables used in DHIS Connector Module will be removed.
This may cause an error saying Unable to update data model using liquibase.xml
after updating the module. I found the solution for this issue from here
This sometimes happens with OpenMRS modules. Ideally liquibase existing changesets should never be modified and if there is a modification required, it should be added as a new and subsequent changeset.
Liquibase makes entries in table liquibasechangelog to keep track of executed changesets with a checksum/hash. When changeset is modified the checksum is found different and this error is encountered.
In above script we removed all tables created by previous version of team module, and also deleted all liquibase entries made by this module to allow module installation start from point zero. Offcourse, if it were production server, we never had deleted the tables. Also we never delete liquibase entries to avoid already executed changesets run again (this sometimes can also cause failed installations)
Deleting every row related to DHIS Connector module in the liquibasechangelog
fixed the issue. Sometimes you may need to delete the report_to_dataset and location_to_orgunit table too
1 Like
piumal1999
(Piumal Rathnayake)
July 25, 2021, 4:12pm
35
Weekly Update - Week 7
From 2021-07-17T18:30:00Z to 2021-07-24T18:30:00Z
Updates:
New run reports UI is completed (Merged)
Fixed the bugs in automation UI and updated the pull request
openmrs:master
← Piumal1999:DCM-50
opened 09:22PM - 03 Jul 21 UTC
## The issue I worked on
See [https://issues.openmrs.org/browse/DCM-50](https:/… /issues.openmrs.org/browse/DCM-50)
## Description of what I changed:
Upgraded the Automation(Scheduling) Functionality to work with automated location mappings
## Preview
https://vimeo.com/578453879
Created JIRA epic and issue for user privileges
Sent the pull request for creating user privileges
openmrs:master
← Piumal1999:DCM-53
opened 02:17PM - 23 Jul 21 UTC
## The issue I worked on
See [https://issues.openmrs.org/browse/DCM-53](https:/… /issues.openmrs.org/browse/DCM-53)
## Description of what I changed:
Created the set of module privileges
cc: @akshika47 @jayasanka
1 Like
piumal1999
(Piumal Rathnayake)
July 31, 2021, 9:14pm
36
Weekly Meeting (Week 8) - 2021-07-30T18:30:00Z
Attendees: @akshika47 @piumal1999
Updates:
Automated location mapping feature is completed now
@jayasanka merged the PR for the Upgraded Automation feature
Started working on the User Access Control System
Added the privileges to the module context (Merged)
Create the set of issues on JIRA
Updated the Location mapping UI to work with the privileges
Updated the Automation UI, Run Reports UI, Failed Data UI to work with the privileges
Updated the Create and Manage Mapping UIs to work with the privileges
Updated the Configure DHIS Connection UI to work with the privileges
Next week:
Completing the user access control system
need to merge the remaining Pull requests
need to finalize the draft Pull requests and make them ready for review.
Updating the documentation by adding the location mapping feature details
updating the github repo readme
updating the wiki page
Start working on UX issues
piumal1999
(Piumal Rathnayake)
August 1, 2021, 9:14am
37
Hi. The user access control system is almost completed now. I sent pull requests for adding privileges to all the pages except the import/export pages. All the details and screenshots are posted in this thread: DHIS Connector Module - User Access Controlling
These are the Pull requests for adding privileges:
@jayasanka @akshika47 Could you please review and merge these. Thank you
2 Likes
piumal1999
(Piumal Rathnayake)
August 5, 2021, 11:38am
38
Hi @dkayiwa , Could you also please review and merge these pull requests. I have added the pull request links to jira as well.
Thanks in advance
dkayiwa
(Daniel Kayiwa)
August 5, 2021, 1:13pm
39
@piumal1999 did your primary mentor take a look at them?
akshika47
(Akshika Wijesundara)
August 7, 2021, 5:29am
40
@piumal1999 @dkayiwa I will review these and merge them before the end of the day.
1 Like