GSoC-2020: Switching from XML Mappings to Annotations on OpenMRS domain Objects

Development
41

@alinmihaila99, I’m not sure there exists any work done for such use case. Basically you want to leverage the annotation @Inheritance(strategy = InheritanceType.JOINED) on the Order entity and going ahead to annotate the subclasses with @Entity then annotating the rest of the domains’ properties accordingly.

42

Hi @ruhanga, I tried to run ValidateHibernateMappingsDatabaseIT from IntellIJ and this time it failed for class ProgramWorkflowState, I don’t know why when I ran the commmand in terminal it passed. The error message was:

org.hibernate.tool.schema.spi.SchemaManagementException: Schema-validation: missing column [date_retired] in table [program_workflow_state]

43

@alinmihaila99, you could employ the advise given by @ibacher to address this for fields unknown to the appropriate liquibase changeset.

In this case, you might have to do something like

@Transient
@Override
public Date getDateRetired() {
		return super.getDateRetired;
}

I believe this would be opportunity to address issues have since risen when switching to annotation from hibernate mappings.

44

@alinmihaila99, for these changesets you could refer to this .

45

Hi @ruhanga, I tried to use @Override and @Transient to resolve the missing columns for the class CohortMembership but I still have the missing columns error. This is what I tried to do. Is it something I miss?

46

And one more question @ruhanga . ConceptReferenceTermMap and ConceptMap both extends ConceptBaseMap and in their mapping there is the mapping for the superclass, but there are some columns that are different. How should I annotate the class ConceptBaseMap? Should I use @AttributeOverride to override the column that is not the same as in ConceptMap?

47

@alinmihaila99, do you have atleast a draft PR to look at?

48

Hoping that you are referring to BaseConceptMap yes. You will want to do something along the following lines, where in the end you’d annotate the common fields in the base class and where necessary override them in the subclasses:

@MappedSuperclass
public abstract class BaseConceptMap extends BaseOpenmrsObject implements Auditable {
     ....
     ....
}

and

@Entity
@Table(..)
// Where necessary: @AttributeOverride(...)
public class ConceptReferenceTermMap extends BaseConceptMap {
    ....
}

@Entity
@Table(..)
// Where necessary: @AttributeOverride(...)
public class ConceptMap extends BaseConceptMap {
    ....
}

I’m not sure why BaseConceptMap was annotated like all the other BaseOpenmrs* @MappedSuperclasss.

@dkayiwa, @ibacher, @mogoodrich, @wyclif, do you know and/or do you have any preference on this?

49

@ruhanga i did this but travis failed for 1 check. Can you have a look at the PR?

50

I could not locate any PR on CohortMembership. Could you share a link to it if any?

51

Sure. https://github.com/openmrs/openmrs-core/pull/3453

52

Hi @ruhanga, I had a problem after removing the bin files from the PR’s. After doing this the security snyk failed. Here is one PR I talk about. Can you have a look, please?

53

@alinmihaila99, I’ve left a comment on the PR. Thanks for the observation.

54

Hi @ruhanga, can you have a look at this travis log please? I really don’t know what happend.

55

Hi @alinmihaila99, I left a comment on the PR.

1 Like
56

Hi @ruhanga, I had an error similar to that one from this travis log. Can you have a look, please?

57

@alinmihaila99, I left a comment on the PR.