GSOC 2019: OpenMRS Atlas 3.1

[heliostrike (Sai Sandeep Mutyala)]

What do you use to create such amazing mockups?!?!?!?!

I updated the PR with the necessary changed, but I didn’t entirely understand this point.

@burke

When search box gains focus, do a select() to select all text to existing text will be replaced by next text by default (re-opening search box and finding your last search is fine, but invoking search and starting to type should not add text to the end of the previous search by default).

I updated the PR with select(), but didn’t quite get the text after that.

@burke

I’m not a fan of using the Ctrl key for search. It’s non-standard and interferes with other normal behaviors (e.g., switching the browser to full screen using Ctrl+Cmd+F on a Mac invokes a search). Can we instead capture Ctrl+F (Cmd+F on Mac)? That’s the standard search key and there’s little utility for the native search.

I feel a bit stupid for not doing this earlier, but turns out event.preventDefault() fixes the issue we had with ‘/’ in mozilla. So… is ‘/’ ok? :'p

@burke

Either is fine w/ me. You can just update the existing PR. Have you seen plot.ly?

Tomorrow’s Sunday, so I’ll make sure to update it by the end of the day (assuming I won’t hit too many road blocks). Also, we would want buttons for the RSS feed and the data page on the top-right corner of atlas page, wouldn’t we?

Merge conflicts give me something to do, so that’s nice (if only resolving them would give github contributions! I need more green!). Anyway, fixed them.