GSoC 2018 - OAuth Module Enhancements And SMART Apps Support Project

prabodhk · June 2, 2018, 9:21am

Yep I understood now. Thanks alot

prabodhk · June 2, 2018, 9:22am

For now, the dao here is never used. So I am leaving it commented out.

@mavrk feel free to merge my code

prabodhk · June 8, 2018, 9:35pm

@mavrk please have a look at my pull request : https://github.com/openmrs/openmrs-module-oauth2/pull/13

Now we are able to see the registered smart app list and also able to run the selected one.

Pressing the “Run” button redirects us to the smart app’s launch url passed with two parameters, iss and launch. The launch parameter here is the launch value which is generated as we run the app and is stored in the db too.

Also I have done all the major minor changes required after analyzing my code till date.

Please review and give feedback

mavrk · June 9, 2018, 7:24am

Good work @pkatopenmrs I’ll not merge your work for now. Complete the additions to AccessConfirmationController and run a demo SMART application either from the SMART gallery or the sample SMART application I gave you Then, we’ll be good to go. You have made good progress do far. The first major deliverable should be ready before the first evals

prabodhk · June 9, 2018, 6:53pm

Thank you @mavrk! Yes I hope we complete the first deliverable soon

prabodhk · June 28, 2018, 4:31pm

@mavrk I added the CustomTokenEnhancer as we discussed on call today. Happy to tell you that its working fine .

You can have a look at the changes here : OA-15:Returning proper Conformance Statement response and properly running SMART apps by PKatGITHUB · Pull Request #14 · openmrs/openmrs-module-oauth2 · GitHub

The pull request also contains the changes related to the correct conformance statement format.

On running the pea SMART App, now I am getting the error as :

WARN - ExceptionHandlingInterceptor.createOperationOutcome(135) |2018-06-28 21:53:21,547| Failure during REST processing: ca.uhn.fhir.rest.server.exceptions.InvalidRequestException: Invalid request: The FHIR endpoint on this server does not know how to handle GET operation[Observation] with parameters [[patient]]

I think that what this app is now requesting is not supported by the FHIR module?

Please correct me if I am wrong.

mavrk · June 28, 2018, 4:41pm

I think it’d be better if you tell us what the exact request is.

prabodhk · June 28, 2018, 4:53pm

http://localhost:8080/openmrs/ws/fhir/Observation?patient=39660707-574b-11e8-b5ce-a81e847f67bb

@mavrk this is the request.

mavrk · June 28, 2018, 7:18pm

@harsha89 Prabodh here is getting trouble running a SMART App which runs this FHIR query. Any ideas ?

harsha89 · June 29, 2018, 4:46am

@mavrk is this request isn’t working is the problem?

prabodhk · June 29, 2018, 6:53am

Yes @harsha89 the problem is that the request is not working. This is the log :

harsha89 · June 29, 2018, 12:22pm

shall we do a quick debug and see? It seems particular search pattern isn’t supported. Can you check following observation resource controller and confirm. Then we might need to add get observations by patient.

github.com

openmrs/openmrs-module-fhir/blob/master/omod/src/main/java/org/openmrs/module/fhir/providers/RestfulObservationResourceProvider.java

/*
 * The contents of this file are subject to the OpenMRS Public License
 * Version 1.0 (the "License"); you may not use this file except in
 * compliance with the License. You may obtain a copy of the License at
 * http://license.openmrs.org
 *
 * Software distributed under the License is distributed on an "AS IS"
 * basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See the
 * License for the specific language governing rights and limitations
 * under the License.
 *
 * Copyright (C) OpenMRS, LLC.  All Rights Reserved.
 */
package org.openmrs.module.fhir.providers;

import ca.uhn.fhir.rest.annotation.Create;
import ca.uhn.fhir.rest.annotation.Delete;
import ca.uhn.fhir.rest.annotation.IdParam;
import ca.uhn.fhir.rest.annotation.Read;
import ca.uhn.fhir.rest.annotation.RequiredParam;

This file has been truncated. show original

prabodhk · June 29, 2018, 12:50pm

@harsha89 as you can see here : https://github.com/openmrs/openmrs-module-fhir/blob/40a0f82e6825850ed7fb37dae3405dea953f0e32/omod/src/main/java/org/openmrs/module/fhir/providers/RestfulObservationResourceProvider.java#L139

this method must help the request with “patient” as parameter. Then why the request is not working?

harsha89 · June 29, 2018, 12:55pm

Most probably this can be due to HAPI FHIR version upgrades. We need to see why it’s failing with a quick debug. Let me know if you can do it. Else I might be able to check this on Sunday.

prabodhk · June 29, 2018, 1:32pm

I will update you soon

prabodhk · June 29, 2018, 8:25pm

@harsha89 I tried but couldn’t figure out much about the issue. Can you please help You can try it on Sunday. I will wait

prabodhk · July 2, 2018, 7:12am

@harsha89 any updates on this?

harsha89 · July 2, 2018, 3:02pm

@pkatopenmrs sorry I still didn’t had a chance to look at this. Were you able to add a debug point to controller and check why it’s not getting invoked? I should be able to check this tomorrow.

prabodhk · July 2, 2018, 3:15pm

@harsha89 actually the controller seems to be working fine with other type of requests. I tried but could not figure out the problem. Take your time and help me

Regards

prabodhk · July 6, 2018, 7:57pm

@harsha89 any updates on this?