fix config.xml dtd file version 1.6

Development
,
6

@mksd good thought. But I wonder if its not better to go with moduleId since this reflects what we have in our code at https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/module/ModuleConditionalResource.java#L92-L98

which is what this xml represents in the end I guess. I am not sure how much moduleId’s and artifactId’s diverge.

These changes would make it to

<conditionalResources>
  <conditionalResource>
      <path>/lib/yourmodule-api-1.10.*</path>
      <loadIfModulePresent>
          <openmrsModule>
              <moduleId>metadatasharing</artifactId>
              <version>1.*</version>
          </openmrsModule>
          <openmrsModule>
              <moduleId>metadatamapping</artifactId>
              <version>1.*</version>
          </openmrsModule>
      </loadIfModulePresent>
  </conditionalResource>
</conditionalResources>

If you are ok (@mksd @darius @dkayiwa) with this I’ll create the 1.6 dtd, adapt the code in the ModuleFileParser, the wiki’s https://wiki.openmrs.org/display/docs/Supporting+different+OpenMRS+versions, https://wiki.openmrs.org/display/docs/Module+Config+File

Another search on github for configVersion 1.6 also doesnt yield a match.

1 Like