Developing the "OCL for OpenMRS" Application

karuhanga · October 9, 2019, 9:16pm

Hey @akanter, kindly use qa for testing for the moment, the demo deployment for the UI currently has newer code that depends on some recently made backend changes.

akanter · October 10, 2019, 2:23pm

Thank you. On QA, I cannot create a new CODED concept. The option is not available. I cannot map to SNOMED as it is not in the sources, and when I try to map to something else, it is not saved.

WE NEED TO IMMEDIATELY UPDATE THE SITE (QA or DEMO) TO BE ABLE TO FULLY TEST BEFORE RELEASING TO PRODUCTION.

karuhanga · October 10, 2019, 3:57pm

In regards to this, recall we restricted this option to only concepts where we have an option of adding answers.

There are no external sources on qa at the moment. So you would have to search for and find the particular concept.

karuhanga · October 10, 2019, 4:07pm

Just spoken to @raff and the changes will be deployed to staging(https://openmrs.staging.openconceptlab.org/) by end of tomorrow.

karuhanga · October 14, 2019, 9:59am

https://openmrs.staging.openconceptlab.org is now up.

c.antwi · October 14, 2019, 1:52pm

Are we now in a position to do a full testing ?

@herbert24 can you look into this ?

herbert24 · October 14, 2019, 3:00pm

yes surely

akanter · October 15, 2019, 2:44pm

I am sorry but I am a bit frustrated that I have not been able to test on DEMO or QA (which I have logins to). Why do we not have a version which can be installed on all of these servers for testing? I need to be able to test realworld mapping to actual sources and what is the status of the subscription module testing? Do we need another call?

karuhanga · October 15, 2019, 4:33pm

Sorry about this @akanter, is there any reason you can’t use staging? I could ask @raff to deploy to demo, but it will be the same deployment anyway.

akanter · October 15, 2019, 7:16pm

I will need login credentials for staging. thanks.

karuhanga · October 15, 2019, 8:31pm

Please signup here(https://staging.openconceptlab.org/) and use those credentials to login. It is the same workflow for when you don’t have an account.

karuhanga · October 21, 2019, 11:21am

Hey @akanter, @herbert24 any progress on this?

herbert24 · October 25, 2019, 7:26am

@karuhanga @c.antwi been in the uganda emrs hackathon but am picking up on this during this weekend

herbert24 · October 29, 2019, 8:29am

the full tests of OCL are on going here https://docs.google.com/spreadsheets/d/14kri4NDR7k1BAODd5aLGysjHJmcymuj_404Ho7H0o4c/edit#gid=0 @karuhanga kindly add other test scenarios that you think we can have cc @karuhanga @burke @darius @christine @akanter @raff @maurya @jennifer @dkayiwa @paynejd

herbert24 · October 29, 2019, 9:19am

@karuhanga @raff @christine are you here please i cannot get any concepts when at https://openmrs.staging.openconceptlab.org/ while trying to filter using CEIL,waiting for your response here ASAP.

raff · October 29, 2019, 11:13am

I’m not in position to help, because https://staging.openconceptlab.org/search/?q= does show concepts correctly. Maybe something on the client side?

herbert24 · October 29, 2019, 11:19am

every thing looks to be fine now.i was accessing them from a wrong place.thanks

jecihjoy · November 27, 2019, 12:59pm

I have been interacting with the openmrs ocl module for a couple of days now, some issues have been raised concerning the module. I have created a ticket for one of the issues in jira that I want to work on https://issues.openmrs.org/browse/OCLM-68

In the current workflow the module does not allow subscription to specific dictionary versions ; picking up on a dictionary subscription url eg https://api.openconceptlab.org/users/Jecihjoy/collections/MC/v1.3/ The module will only work if the dictionary version is removed from the url to form https://api.openconceptlab.org/users/Jecihjoy/collections/MC With this url the module then imports the latest released version of the dictionary.

My proposed solution is to have the user pass the whole url of a specific released dictionary version they intend to import eg https://api.openconceptlab.org/users/Jecihjoy/collections/MC/v1.3/ and to have the module import the concepts. This is possible because ocl api has an endpoint that handles this request.

That means only passing url to this function;

github.com

openmrs/openmrs-module-openconceptlab/blob/31403ba09d1ec191143c7b90fe6fa236eca4e202/api/src/main/java/org/openmrs/module/openconceptlab/client/OclClient.java#L113


		totalBytesToDownload = -1; //unknown yet

		bytesDownloaded = 0;



		String latestVersion = fetchLatestOclReleaseVersion(url, token);



		GetMethod exportUrlGet = executeExportRequest(url, latestVersion);

		

		return extractResponse(exportUrlGet);

    }



    public GetMethod executeExportRequest(String url, String latestVersion) throws IOException{



		GetMethod exportUrlGet = new GetMethod(url + "/" + latestVersion + "/export");



		HttpClient client = new HttpClient();

		client.getHttpConnectionManager().getParams().setSoTimeout(TIMEOUT_IN_MS);

		client.executeMethod(exportUrlGet);



		if (exportUrlGet.getStatusCode() != 200) {

			throw new IOException(exportUrlGet.getStatusLine().toString());

		}

cc @dkayiwa @raff @ningosi @jdick

raff · November 27, 2019, 1:15pm

I support adding that feature as long as the current behavior of importing the latest if no version is provided is still supported.

If you provide a url to a specific version, then the check for updates button does not make sense and should be disabled with a proper message indicating why.

mogoodrich · November 27, 2019, 5:12pm

I agree… I support that behavior.

@jecihjoy I just started playing around with the module this week, and ran into a few issues but it seems like you are making more progress than me!

Does the download link in OCL for OpenMRS work for you? When I click on it I get an error:

2019-11-27_12-05_1

2019-11-27_12-06

I also get an error when I try to download the CSV from OCL directly.

2019-11-27_12-08_1

I’m assuming/guessing that this may be a permissions issue, but not sure who is currently the admin for OCL (@paynejd @akanter @raff ?).

Also, bigger picture, we (PIH) are considering using OCL for our concept management in the future. @jecihjoy is AMPATH considering using it a well?

Thanks!

Take care, Mark