I just got an answer from codacy’s support.
And identified following issues+solutions
-
Codacy supports automatic loading of rules files (be it checkstyle, eslint, …) from the ROOT of the repository. We currently have 2 checkstyle files one for openmrs and one for webapp. Codacy expects it to be called checkstyle.xml and only loads one from the root directory. Please review my suggested solution so I can implement this: https://issues.openmrs.org/browse/TRUNK-5080 which will sync codacy’s rules with our checktsyle.xml
-
Codacy does not support the checkstyle suppression filter which uses the checkstyle-suppressions.xml. I also checked https://docs.codeclimate.com/docs/checkstyle which doesnt state anything that suggest they do support this. I asked their support and am waiting. This feature as far as I see is only possible with SonarQube since it collects the report from the maven checkstyle plugin where this suppression filter is configurable. Current solution: codacy (in their UI) is configured to ignore test classes entirely.
-
I added another task to update our maven checkstyle plugin which is very outdated: https://issues.openmrs.org/browse/TRUNK-5081 as part of this we could update our checkstyle.xml rules if anyone has suggestions.
@burke can you please remove the integration you added at https://www.codacy.com/app/infrastructure/openmrs-core/dashboard I now have permission to add the integration at https://www.codacy.com/app/openmrs/openmrs-core/dashboard
If we are not happy with codacy we can still switch to another provider later or stick with SonarQube since they are (after #1 is done) all based on the same checkstyle.xml rules, at any rate we should clean this up 