After reading through @ibacher 's post in respect to first time contributors, all our modules for first time contributors will require approval for Github Actions to deploy their changes to the server. The logic behind this is to help module maintainers combat bad actors, however this has downside for us (and first-time contributors on our modules) automated tests won’t run to provide feedback to the committer that their PR is good (tests passing). Similarly, we won’t be able to tell that whether or new PR is ready for review until those tests are run. A @dev/3+ will need to “touch” each PR request or change to a PR request every time before the tests will run.
As the QA support team is increasing, there might be a need for @k.joseph @christine @grace to do the approvals on such commits to enable the new committers be able to see the test report before reviews are made on such PRs. I was going through the commits from our contributors and found one in such category.
cc: @ibacher @burke @dkayiwa @sharif @jennifer @cintiadr
1 Like