Attachments: Problem rendering complex obs created outside of module

mksd · May 5, 2020, 8:51am

Corrected here:

ATT-38: ComplexViewHelper2_0 to log a warning when unsupported view.

gcliff · May 5, 2020, 9:49am

i pulled the latest changes and tested them though the module still fails to attach images when you select ImageHandler outside the attachment api handlers.

mksd · May 5, 2020, 11:18am

Thanks @gcliff, what’s the stack trace now? Can you share it on https://dpaste.org/?

gcliff · May 5, 2020, 12:56pm

https://pastebin.com/CCFtwPs7

The new changes merged seem to have fixed this initial error here https://pastebin.com/xSUUbHnq

mksd · May 5, 2020, 1:09pm

Thanks @gcliff. However something’s wrong with the reported error:

NullPointerException
  at AttachmentsController.downloadDocument(AttachmentsController.java:115)

But line 115 is a blank line, see here. Are you sure you’re running the build out of the latest master branch?

gcliff · May 5, 2020, 1:37pm

yes @mksd ,i have just reproduced the issue again and still the same error logs from the server

mksd · May 5, 2020, 4:38pm

Indeed, I tried this locally and same weird stuff with line 115.

Anyway, I found the issue, it’s in this deprecated controller: AttachmentsController. Fixed here:

ATT-39: Old AttachmentsController to use ComplexViewHelper when fetcting obs.

Could you guys try it?

gcliff · May 6, 2020, 6:29am

@mksd i have tested the module with the latest changes merged and it works with handlers outside the attachment api …

reagan · May 6, 2020, 6:48am

Thank you @gcliff for testing it out