App Framework: AF-59 Extensions to support a "requiredStates" property

mogoodrich · August 29, 2019, 3:36pm

Interesting… the java object ProgramWorkflowState still have a name property because it inherits from BaseOpenMRSMetadata, but that is never stored behind the scenes:

github.com

openmrs/openmrs-core/blob/2.2.x/api/src/main/resources/org/openmrs/api/db/hibernate/ProgramWorkflowState.hbm.xml

<?xml version="1.0"?>
<!--

    This Source Code Form is subject to the terms of the Mozilla Public License,
    v. 2.0. If a copy of the MPL was not distributed with this file, You can
    obtain one at http://mozilla.org/MPL/2.0/. OpenMRS is also distributed under
    the terms of the Healthcare Disclaimer located at http://openmrs.org/license.

    Copyright (C) OpenMRS Inc. OpenMRS is a registered trademark and the OpenMRS
    graphic logo is a trademark of OpenMRS Inc.

-->
<!DOCTYPE hibernate-mapping PUBLIC
    "-//Hibernate/Hibernate Mapping DTD 3.0//EN"
    "http://www.hibernate.org/dtd/hibernate-mapping-3.0.dtd">   
<hibernate-mapping package="org.openmrs">

	<class name="ProgramWorkflowState" table="program_workflow_state">

		<id name="programWorkflowStateId" type="java.lang.Integer" column="program_workflow_state_id">

This file has been truncated. show original

So @mksd so I think that line that does the setName just ends up putting it into the ether somewhere…

Yeah I would agree with @mseaton that we’d want to support a pattern where you specify a workflow and a state. And you would reference a workflow either by it’s name or uuid, and a state by the underlying concept (name, uuid or mapping).

I could see I us wanted to support more complex logic in the future, but I think a list of workflow/workflow state pairs ORed together is great for now and then we could update if needed in the future.

Thanks for working on this!

Take care, Mark

fyi @ball @ddesimone I think we’ve talked about wanting to make some forms only available to patients if they are enrolled in a program, and this would facilitate that.