Why are username and password values passed as GET params in idgen module

jmaina · November 21, 2016, 11:23am

Recently I was working on some functionality to make REST requests against the idgen module, but just realized that the username and password values are passed as get params and not the basic auth format I was expecting. It works but I thought there could be a reason for this approach. Any idea why this is the case? see

github.com

openmrs/openmrs-module-idgen/blob/master/omod/src/main/java/org/openmrs/module/idgen/web/controller/IdentifierSourceController.java#L196


                               @RequestParam(required=false, value="username") String username,
                               @RequestParam(required=false, value="password") String password) throws Exception {
	exportIdentifiers(model, request, response, source, 1, comment, username, password);
}


/**
 * Export Identifiers To File
 */
@RequestMapping("/module/idgen/exportIdentifiers")
public void exportIdentifiers(ModelMap model, HttpServletRequest request, HttpServletResponse response,
							   @RequestParam(required=true, value="source") IdentifierSource source,
							   @RequestParam(required=true, value="numberToGenerate") Integer numberToGenerate,
							   @RequestParam(required=false, value="comment") String comment,
                               @RequestParam(required=false, value="username") String username,
                               @RequestParam(required=false, value="password") String password) throws Exception {


    if (StringUtils.isNotBlank(username) && StringUtils.isNotBlank(password)) {
        Context.authenticate(username, password);
    }

@dkayiwa or anyone

dkayiwa · November 21, 2016, 1:50pm

@jmaina basing on this https://issues.openmrs.org/browse/IDGEN-16, and hence https://github.com/openmrs/openmrs-module-idgen/commit/51599cfcb96aa91ff1fc58cef6db17e63b7e447a, i forward this to @darius, @mseaton, @mogoodrich

mogoodrich · November 21, 2016, 6:01pm

I don’t remember 100%, but I suspect that it wasn’t done for any particular reason rather than that this was the way we thought of doing it at the time.

Mark