Q query param in DrugSearchHandler

gayanw · July 9, 2017, 5:57pm

Why is the need to explicitly specify q as an query pram in DrugSearchHandler1_10, but not in any other search handler.

github.com

openmrs/openmrs-module-webservices.rest/blob/master/omod-1.10/src/main/java/org/openmrs/module/webservices/rest/web/v1_0/search/openmrs1_10/DrugSearchHandler1_10.java#L41-L53


	public static final String REQUEST_PARAM_QUERY = "q";
	
	public static final String REQUEST_PARAM_LOCALE = "locale";
	
	public static final String REQUEST_PARAM_EXACT_LOCALE = "exactLocale";
	
	@Autowired
	@Qualifier("conceptService")
	ConceptService conceptService;
	
	SearchQuery searchQuery = new SearchQuery.Builder("Allows you to search for drugs, it matches on drug"
	        + " names, concept names of the associated concepts or the concept reference term codes of the"
	        + " drug reference term mappings").withRequiredParameters(REQUEST_PARAM_QUERY)

q to my understanding is a generic search param that is added to any resource operation that has searching capability. The reason for raising my concern is that this causes duplicate q params being added to GET /drug.

So I just want to confirm that if it’s okay if I remove the q param from the DrugSearchHandler1_10?

@pascal @bholagabbar @teleivo

dkayiwa · July 16, 2017, 7:45am

Your suggestion makes a lot of sense to me. So go ahead and remove it. Create a ticket and link to this talk thread. Remember to do some random testing to ensure all is as well as before.