# OpenMRS ID v2.1 Platform Improvements **URL:** \ **Category:** GSoC\ **Tags:** gsoc2015, openmrs-id\ **Created:** [March 11, 2015, 2:45pm UTC](https://talk.openmrs.org/t/openmrs-id-v2-1-platform-improvements/1362 "2015-03-11T14:45:50Z")\ **Posts on this page:** 20\ **Page:** 1
**Author:** ![r0bby](https://talk.openmrs.org/user_avatar/talk.openmrs.org/r0bby/32/6479_2.png) [@r0bby](https://talk.openmrs.org/u/r0bby)\ **Post date:** [March 11, 2015, 2:45pm UTC](https://talk.openmrs.org/t/openmrs-id-v2-1-platform-improvements/1362/1 "2015-03-11T14:45:50Z")
Welcome potential Google Summer of Code 2015 interns! I am mentoring the OpenMRS ID project this year and am opening up this thread for discussion and questions. I will be the primary mentor, and @elliott will be backup mentor should I be unavailable for any reason. If you have questions, ask here! ---
**Author:** ![approce](https://talk.openmrs.org/user_avatar/talk.openmrs.org/approce/32/642_2.png) [@approce](https://talk.openmrs.org/u/approce)\ **Post date:** [March 11, 2015, 3:26pm UTC](https://talk.openmrs.org/t/openmrs-id-v2-1-platform-improvements/1362/2 "2015-03-11T15:26:46Z")
Hey, you have just updated project idea šŸ˜ƒ - Investigate rewriting all JS files using either ES6 or Coffeescript (see js2coffee or the node module of js2coffee) That will be interesting! - Support two-factor authentication for OAuth-based sign ins Should we use SMS verfication as second factor? Or any other requirements? ---
**Author:** ![r0bby](https://talk.openmrs.org/user_avatar/talk.openmrs.org/r0bby/32/6479_2.png) [@r0bby](https://talk.openmrs.org/u/r0bby)\ **Post date:** [March 11, 2015, 6:28pm UTC](https://talk.openmrs.org/t/openmrs-id-v2-1-platform-improvements/1362/3 "2015-03-11T18:28:37Z")
> [@approce](#): > > Hey, you have just updated project idea > > Investigate rewriting all JS files using either ES6 or Coffeescript (see js2coffee or the node module of js2coffee) > > That will be interesting! > > Support two-factor authentication for OAuth-based sign ins > > Should we use SMS verfication as second factor? Or any other requirements? Yup šŸ™‚ I did ā€“ I think itā€™s a good change šŸ™‚ ---
**Author:** ![elliott](https://talk.openmrs.org/user_avatar/talk.openmrs.org/elliott/32/965_2.png) [@elliott](https://talk.openmrs.org/u/elliott)\ **Post date:** [March 11, 2015, 6:37pm UTC](https://talk.openmrs.org/t/openmrs-id-v2-1-platform-improvements/1362/4 "2015-03-11T18:37:33Z")
> [@approce](#): > > Support two-factor authentication for OAuth-based sign ins > > Should we use SMS verfication as second factor? Or any other requirements? Take a look (and add your voice!) to the [design discussion on two-factor auth](https://talk.openmrs.org/t/two-factor-authentication/1193). ---
**Author:** ![plypy](https://talk.openmrs.org/user_avatar/talk.openmrs.org/plypy/32/505_2.png) [@plypy](https://talk.openmrs.org/u/plypy)\ **Post date:** [March 12, 2015, 8:18am UTC](https://talk.openmrs.org/t/openmrs-id-v2-1-platform-improvements/1362/5 "2015-03-12T08:18:33Z")
Hi @r0bby, Iā€™m wondering how much frontend knowledge is neededā€¦ As Iā€™ve been focusing on backend stuff and just started to learn frontend things. ---
**Author:** ![plypy](https://talk.openmrs.org/user_avatar/talk.openmrs.org/plypy/32/505_2.png) [@plypy](https://talk.openmrs.org/u/plypy)\ **Post date:** [March 12, 2015, 9:46am UTC](https://talk.openmrs.org/t/openmrs-id-v2-1-platform-improvements/1362/6 "2015-03-12T09:46:35Z")
Also, Iā€™ve already done some work for [ID-89](https://issues.openmrs.org/browse/ID-89)(reimplement the ldap.js) in my [ID-89](https://github.com/Plypy/openmrs-contrib-id/tree/ID-89) branch. However, Iā€™ve made some changes for the APIs of ldap.js. Here is the change list Iā€™ve logged, ##ChangeLog begin Note that the ldap.js shouldnā€™t be used directly, as you shouldnā€™t directly contact the LDAP server, or you will break the consistency between mongo and LDAP. Most functionsā€™ interfaces havenā€™t changed, here are few changed: ###exports.getUser() - The result it returns will not contain the `objectClass` field, nor the `conf.user.secondaryemail`. - All the attributes it returned will have same names, instead of odd LDAP stuff like `cn`, `dn` or what. - It wonā€™t pass back an error for not finding any user. Instead, if no user is found, the userobj in `cb(err, userobj)` will simply be `undefined`. You may check it yourself. ###export.addUser() - It accepts a normal user object rather than a series of attributes, and it wonā€™t automatically generate the `displayName` field, but leave it to the programmer, as well as the `groups`. ###exports.updateuser() - It now only supports to update the ordinary attributes, not including those ldap specific attributes like `objectClass`, `pwdPolicySubentry`. ###others - `changePassword` is deprecated, but `resetPasword` is reserved. Whatā€™s more, `resetPassword`, now will only accept username, not email. ## ChangeLog End What do you guys think? I made these decisions all by my distinct, so some might be wrong. But in my opinion, these changes will only affect a tiny of our project. As I noted > Note that the ldap.js shouldnā€™t be used directly, as you shouldnā€™t directly contact the LDAP server, or you will break the consistency between mongo and LDAP. So there are only a few other components used it. ---
**Author:** ![r0bby](https://talk.openmrs.org/user_avatar/talk.openmrs.org/r0bby/32/6479_2.png) [@r0bby](https://talk.openmrs.org/u/r0bby)\ **Post date:** [March 12, 2015, 6:31pm UTC](https://talk.openmrs.org/t/openmrs-id-v2-1-platform-improvements/1362/7 "2015-03-12T18:31:39Z")
@plypy There will be a lil bit of bothā€¦but mostly changes to existing viewsā€¦two-factor authentication will require some kind of a way for people to type in the codeā€¦but thatā€™s itā€¦ ---
**Author:** ![plypy](https://talk.openmrs.org/user_avatar/talk.openmrs.org/plypy/32/505_2.png) [@plypy](https://talk.openmrs.org/u/plypy)\ **Post date:** [March 17, 2015, 1:02am UTC](https://talk.openmrs.org/t/openmrs-id-v2-1-platform-improvements/1362/8 "2015-03-17T01:02:28Z")
Ahhhā€¦ school days are keeping me busy, I was doing all kinds of experiments. Like OS, Network, Data Science etc. It was all back-end or theory stuff that Iā€™ve been learning, but since the Dashboard has pretty much front-end part, Iā€™m digging it. It just bothers me, you know, when I have some issues fixed but cannot put it into use because of no pretty interface. Like [ID-86](https://issues.openmrs.org/browse/ID-86), which I have already worked out a prototype long ago. Itā€™s really a pain in the ass. Anyhow, do you have any recommendations, @r0bby. Currently, Iā€™m learning jQuery from this book[Learning jQuery](http://www.amazon.com/Learning-jQuery-Fourth-Jonathan-Chaffer/dp/178216314X/ref=sr_1_1?ie=UTF8&qid=1426553912&sr=8-1&keywords=learning+jQuery), and some CSS/HTML knowledge from w3c school. The application period has already opened, youā€™ll have my application soon. ---
**Author:** ![r0bby](https://talk.openmrs.org/user_avatar/talk.openmrs.org/r0bby/32/6479_2.png) [@r0bby](https://talk.openmrs.org/u/r0bby)\ **Post date:** [March 17, 2015, 7:07am UTC](https://talk.openmrs.org/t/openmrs-id-v2-1-platform-improvements/1362/9 "2015-03-17T07:07:03Z")
> [@plypy](#): > > It just bothers me, you know, when I have some issues fixed but cannot put it into use because of no pretty interface. Like ID-86, which I have already worked out a prototype long ago. Itā€™s really a pain in the ass. Right now we got GCI contributions to trudge through ā€“ Iā€™m mostly done with that ā€“ just need to make decisions but that will be done before May. > [@plypy](#): > > It just bothers me, you know, when I have some issues fixed but cannot put it into use because of no pretty interface. Like ID-86, which I have already worked out a prototype long ago. Itā€™s really a pain in the ass. If no interface exists ā€“ make it ā€“ but this isnā€™t a hard to implement solution. > [@plypy](#): > > The application period has already opened, youā€™ll have my application soon. Canā€™t wait for it, youā€™ll be held to the same standard so knock it out of the park! šŸ˜„ ---
**Author:** ![plypy](https://talk.openmrs.org/user_avatar/talk.openmrs.org/plypy/32/505_2.png) [@plypy](https://talk.openmrs.org/u/plypy)\ **Post date:** [March 17, 2015, 10:19am UTC](https://talk.openmrs.org/t/openmrs-id-v2-1-platform-improvements/1362/10 "2015-03-17T10:19:20Z")
> [@r0bby](#): > > If no interface exists ā€“ make it ā€“ but this isnā€™t a hard to implement solution. I know, itā€™s not hard to implement. Just manipulating those DOM stuffs according to the docs isnā€™t a hard thing for me, but working out a pretty looking page, you know. Anyway, Iā€™m learning. ---
**Author:** ![dmytro.trifonov](https://talk.openmrs.org/letter_avatar/dmytro.trifonov/32/5_5575768a8748004e209b776fc1b2916d.png) [@dmytro.trifonov](https://talk.openmrs.org/u/dmytro.trifonov)\ **Post date:** [March 17, 2015, 10:30am UTC](https://talk.openmrs.org/t/openmrs-id-v2-1-platform-improvements/1362/11 "2015-03-17T10:30:53Z")
Hi all! My name is Dmytro Trifonov, and I am insterested to work on this project during GSoC 2015. I start to learn it (source code) last weekend, and soon I will prepare list of my ideas and proposals. Some words about myself: I am working on different node.js projects more than 2 years, I worked with such technologies: server side - Express.js, MongoDB (mongoose module), Redis (nohm module), postgresql, mysql, [socket.io](http://socket.io); frontend - Angular.js, JQuery, require.js, Bootstrap. Also i have worked with OpenMRS system before, and have good knowledge of OpenMRS REST API and database structure. ---
**Author:** ![r0bby](https://talk.openmrs.org/user_avatar/talk.openmrs.org/r0bby/32/6479_2.png) [@r0bby](https://talk.openmrs.org/u/r0bby)\ **Post date:** [March 17, 2015, 11:15am UTC](https://talk.openmrs.org/t/openmrs-id-v2-1-platform-improvements/1362/12 "2015-03-17T11:15:02Z")
> [@plypy](#): > > I know, itā€™s not hard to implement. Just manipulating those DOM stuffs according to the docs isnā€™t a hard thing for me, but working out a pretty looking page, you know. > > Anyway, Iā€™m learning. Bonus points for wireframes šŸ™‚ ā¤ ---
**Author:** ![r0bby](https://talk.openmrs.org/user_avatar/talk.openmrs.org/r0bby/32/6479_2.png) [@r0bby](https://talk.openmrs.org/u/r0bby)\ **Post date:** [March 17, 2015, 11:16am UTC](https://talk.openmrs.org/t/openmrs-id-v2-1-platform-improvements/1362/13 "2015-03-17T11:16:47Z")
> [@dmytro\_trifonov](#): > > Hi all! My name is Dmytro Trifonov, and I am insterested to work on this project during GSoC 2015. I start to learn it (source code) last weekend, and soon I will prepare list of my ideas and proposals. Some words about myself: I am working on different node.js projects more than 2 years, I worked with such technologies: server side - Express.js, MongoDB (mongoose module), Redis (nohm module), postgresql, mysql, [socket.io](http://socket.io); frontend - Angular.js, JQuery, require.js, Bootstrap. Also i have worked with OpenMRS system before, and have good knowledge of OpenMRS REST API and database structure. I look forward to your proposal. Impress me šŸ˜„ ā€“ make me šŸ˜¹ ---
**Author:** ![dmytro.trifonov](https://talk.openmrs.org/letter_avatar/dmytro.trifonov/32/5_5575768a8748004e209b776fc1b2916d.png) [@dmytro.trifonov](https://talk.openmrs.org/u/dmytro.trifonov)\ **Post date:** [March 17, 2015, 5:06pm UTC](https://talk.openmrs.org/t/openmrs-id-v2-1-platform-improvements/1362/14 "2015-03-17T17:06:06Z")
As i see, currently OpenMRS ID uses Node.JS v0.8/Express v3.x. What do you think about upgrading code for latest version of Node.JS, and Express v4.x? ---
**Author:** ![r0bby](https://talk.openmrs.org/user_avatar/talk.openmrs.org/r0bby/32/6479_2.png) [@r0bby](https://talk.openmrs.org/u/r0bby)\ **Post date:** [March 17, 2015, 5:37pm UTC](https://talk.openmrs.org/t/openmrs-id-v2-1-platform-improvements/1362/15 "2015-03-17T17:37:25Z")
> [@dmytro\_trifonov](#): > > As i see, currently OpenMRS ID uses Node.JS v0.8/Express v3.x. What do you think about upgrading code for latest version of Node.JS, and Express v4.x? Barring things didnā€™t break ā€“ Iā€™m fine with this ā€“ but Iā€™m more concerned with keeping things working. I have changes I want to make as wellā€¦letā€™s keep things working. A pull request upgrading code plus passing tests would make me happy. @elliott and @plypy you have any opinions? Since we have pretty open-ended project description ā€“ barring you have good ideas ā€“ wrap it in your proposal and weā€™ll see how it goes. ---
**Author:** ![plypy](https://talk.openmrs.org/user_avatar/talk.openmrs.org/plypy/32/505_2.png) [@plypy](https://talk.openmrs.org/u/plypy)\ **Post date:** [March 18, 2015, 12:50am UTC](https://talk.openmrs.org/t/openmrs-id-v2-1-platform-improvements/1362/16 "2015-03-18T00:50:58Z")
Actually, the ID-Dashboard is fully compatible with Node 0.10.x, which was once the newest version. The reason we havenā€™t upgraded it is that itā€™s not necessary that time. And if you want to change the version, you can do it anytime. Iā€™ve just noticed that Node has released v0.12, under which we havenā€™t tested the Dashboard yet. But, I think, we should not be too hasty, as our platform, like many others, relies on 3rd-party packages heavily. And the v0.12 has just been released in a month, there is a chance that it could break some packages, so letā€™s give it some time. And we once tried to upgrade the Dashboard to 4.x last year, see [ID-55](https://issues.openmrs.org/browse/ID-55). But that update failed because of some weird conflicts to our admin tool, i.e. formage. Nevertheless, we are planning to switch to the keystone.js and deprecate the formage, this could be pick up again. IMO, one thing at a time, letā€™s first migrate to keystone.js. Anyway, you know, new things are great but sometimes they are not necessary, unless you do have very good reason to do it(old version is deprecated, and there are some must-have features in the new one). However, if you really want to upgrade it, make sure it wonā€™t break things. Summary: - Could upgrade node to v0.10, but donā€™t be hasty to upgrade it to v0.12. - Should upgrade the express, but first work on keystone.js. ---
**Author:** ![r0bby](https://talk.openmrs.org/user_avatar/talk.openmrs.org/r0bby/32/6479_2.png) [@r0bby](https://talk.openmrs.org/u/r0bby)\ **Post date:** [March 18, 2015, 5:04am UTC](https://talk.openmrs.org/t/openmrs-id-v2-1-platform-improvements/1362/17 "2015-03-18T05:04:42Z")
> [@plypy](#): > > Could upgrade node to v0.10, but donā€™t be hasty to upgrade it to v0.12. Should upgrade the express, but first work on keystone.js. I agree with @plypy ā€“ go ahead and upgrade node to 0,10 ā€“ make a PR ā€“ but **TEST THINGS!** Work on your proposals šŸ™‚ ---
**Author:** ![plypy](https://talk.openmrs.org/user_avatar/talk.openmrs.org/plypy/32/505_2.png) [@plypy](https://talk.openmrs.org/u/plypy)\ **Post date:** [March 18, 2015, 11:15am UTC](https://talk.openmrs.org/t/openmrs-id-v2-1-platform-improvements/1362/18 "2015-03-18T11:15:06Z")
> [@r0bby](#): > > make a PR It seems that you have misunderstood meā€¦ By ā€˜fully compatibleā€™ I mean, no code needed to rewrite. šŸ˜„We can work on something else. ---
**Author:** ![r0bby](https://talk.openmrs.org/user_avatar/talk.openmrs.org/r0bby/32/6479_2.png) [@r0bby](https://talk.openmrs.org/u/r0bby)\ **Post date:** [March 18, 2015, 1:27pm UTC](https://talk.openmrs.org/t/openmrs-id-v2-1-platform-improvements/1362/19 "2015-03-18T13:27:21Z")
> [@plypy](#): > > It seems that you have misunderstood meā€¦ By ā€˜fully compatibleā€™ I mean, no code needed to rewrite. We can work on something else. Alrighty, Good luck on your proposal. ---
**Author:** ![plypy](https://talk.openmrs.org/user_avatar/talk.openmrs.org/plypy/32/505_2.png) [@plypy](https://talk.openmrs.org/u/plypy)\ **Post date:** [March 18, 2015, 4:14pm UTC](https://talk.openmrs.org/t/openmrs-id-v2-1-platform-improvements/1362/20 "2015-03-18T16:14:18Z")
> [@plypy](#): > > By ā€˜fully compatibleā€™ I mean, no code needed to rewrite Ahhh, I just checked my notes, and I may be too confident on this point. The current Dashboard could pass the unit tests in 0.10, and nothing seems to be wrong on the local server, but thatā€™s all I know. There may be, though unlikely I think, some version-related bugs. As the most recent fix ID-87 is exactly about 0.10 conflict, I might be wrong. Anyway, you canā€™t be too careful. [Next page](https://talk.openmrs.org/t/openmrs-id-v2-1-platform-improvements/1362.md?page=2)