# Missing PatientId

**URL:** <https://talk.openmrs.org/t/missing-patientid/26552>\
**Category:** Development\
**Created:** [January 29, 2020, 11:40am UTC](https://talk.openmrs.org/t/missing-patientid/26552 "2020-01-29T11:40:43Z")\
**Posts on this page:** 20\
**Page:** 1

<div class="post-metadata">

**Author:** ![reagan](https://talk.openmrs.org/user_avatar/talk.openmrs.org/reagan/32/10652_2.png) [@reagan](https://talk.openmrs.org/u/reagan)\
**Post date:** [January 29, 2020, 11:40am UTC](https://talk.openmrs.org/t/missing-patientid/26552/1 "2020-01-29T11:40:44Z")

</div>

While working on RefApp on this ticket [https://issues.openmrs.org/browse/RA-950](https://issues.openmrs.org/browse/RA-950), I came across an error when editing a Visit Date. [https://pastebin.com/tFNNG8MP](https://pastebin.com/tFNNG8MP) is thrown when you save…While the visit date change is well persisted;the response from the serve is not graceful. Can a ticket be created for it? @dkayiwa @mogoodrich @ruhanga @mozzy

---

<div class="post-metadata">

**Author:** ![ruhanga](https://talk.openmrs.org/user_avatar/talk.openmrs.org/ruhanga/32/8318_2.png) [@ruhanga](https://talk.openmrs.org/u/ruhanga)\
**Post date:** [January 29, 2020, 12:22pm UTC](https://talk.openmrs.org/t/missing-patientid/26552/2 "2020-01-29T12:22:02Z")

</div>

Thanks @reagan, did you manage to reproduce this on [demo](https://demo.openmrs.org/) and [qa-refapp](https://qa-refapp.openmrs.org/)? If yes, you may please go ahead to create a ticket for this to unblock you if there’s not one already.

---

<div class="post-metadata">

**Author:** ![reagan](https://talk.openmrs.org/user_avatar/talk.openmrs.org/reagan/32/10652_2.png) [@reagan](https://talk.openmrs.org/u/reagan)\
**Post date:** [January 29, 2020, 12:27pm UTC](https://talk.openmrs.org/t/missing-patientid/26552/3 "2020-01-29T12:27:47Z")

</div>

@ruhanga I tested it locally with sdk of latest snapshot and on qa-refapp as well, demo is currently unavailable…

---

<div class="post-metadata">

**Author:** ![ruhanga](https://talk.openmrs.org/user_avatar/talk.openmrs.org/ruhanga/32/8318_2.png) [@ruhanga](https://talk.openmrs.org/u/ruhanga)\
**Post date:** [January 29, 2020, 12:39pm UTC](https://talk.openmrs.org/t/missing-patientid/26552/4 "2020-01-29T12:39:03Z")

</div>

I just reset the demo, you may as well go ahead to test on it. Feel free to create a ticket that’ll solve your blocker.

---

<div class="post-metadata">

**Author:** ![reagan](https://talk.openmrs.org/user_avatar/talk.openmrs.org/reagan/32/10652_2.png) [@reagan](https://talk.openmrs.org/u/reagan)\
**Post date:** [January 29, 2020, 1:02pm UTC](https://talk.openmrs.org/t/missing-patientid/26552/5 "2020-01-29T13:02:43Z")

</div>

On demo-server it redirects well…

---

<div class="post-metadata">

**Author:** ![reagan](https://talk.openmrs.org/user_avatar/talk.openmrs.org/reagan/32/10652_2.png) [@reagan](https://talk.openmrs.org/u/reagan)\
**Post date:** [January 30, 2020, 11:20am UTC](https://talk.openmrs.org/t/missing-patientid/26552/6 "2020-01-30T11:20:33Z")

</div>

@ruhanga It seems a recent PR merge edited the redirect URL…

---

<div class="post-metadata">

**Author:** ![ruhanga](https://talk.openmrs.org/user_avatar/talk.openmrs.org/ruhanga/32/8318_2.png) [@ruhanga](https://talk.openmrs.org/u/ruhanga)\
**Post date:** [January 30, 2020, 8:16pm UTC](https://talk.openmrs.org/t/missing-patientid/26552/7 "2020-01-30T20:16:16Z")

</div>

Thanks @reagan. @mozzy could this be bootstrap related?

---

<div class="post-metadata">

**Author:** ![reagan](https://talk.openmrs.org/user_avatar/talk.openmrs.org/reagan/32/10652_2.png) [@reagan](https://talk.openmrs.org/u/reagan)\
**Post date:** [January 30, 2020, 8:23pm UTC](https://talk.openmrs.org/t/missing-patientid/26552/8 "2020-01-30T20:23:39Z")

</div>

I think it’s an issue with the controller… The searchparams it gives on return find in this file…omod/src/main/java/org/openmrs/module/coreapps/fragment/controller/visit/VisitDatesFragmentController.java…

---

<div class="post-metadata">

**Author:** ![ruhanga](https://talk.openmrs.org/user_avatar/talk.openmrs.org/ruhanga/32/8318_2.png) [@ruhanga](https://talk.openmrs.org/u/ruhanga)\
**Post date:** [January 30, 2020, 8:52pm UTC](https://talk.openmrs.org/t/missing-patientid/26552/9 "2020-01-30T20:52:46Z")

</div>

Okay @reagan , looks like there is a jQuery conflict before/after a successful post is made though. Here is a caught error in the Chrome Dev tool,

```
TypeError: $.getJSON(...).success is not a function
```

---

<div class="post-metadata">

**Author:** ![ruhanga](https://talk.openmrs.org/user_avatar/talk.openmrs.org/ruhanga/32/8318_2.png) [@ruhanga](https://talk.openmrs.org/u/ruhanga)\
**Post date:** [January 30, 2020, 9:18pm UTC](https://talk.openmrs.org/t/missing-patientid/26552/10 "2020-01-30T21:18:08Z")

</div>

@reagan you could go ahead to create a ticket that resolves this. The `success()` method was deprecated in preference of `done()` in jQuery 3.4.1 . This means correcting the occurrences of this method such as the one below in that js file.

> <https://github.com/openmrs/openmrs-module-coreapps/blob/master/omod/src/main/webapp/resources/scripts/custom/visits.js#L134>

---

<div class="post-metadata">

**Author:** ![reagan](https://talk.openmrs.org/user_avatar/talk.openmrs.org/reagan/32/10652_2.png) [@reagan](https://talk.openmrs.org/u/reagan)\
**Post date:** [January 31, 2020, 6:35am UTC](https://talk.openmrs.org/t/missing-patientid/26552/11 "2020-01-31T06:35:56Z")

</div>

Alright then

---

<div class="post-metadata">

**Author:** ![reagan](https://talk.openmrs.org/user_avatar/talk.openmrs.org/reagan/32/10652_2.png) [@reagan](https://talk.openmrs.org/u/reagan)\
**Post date:** [February 2, 2020, 1:00pm UTC](https://talk.openmrs.org/t/missing-patientid/26552/12 "2020-02-02T13:00:29Z")

</div>

@ruhanga Kindly review the issue here and advice on how to make it more clear. [https://issues.openmrs.org/browse/RA-1696](https://issues.openmrs.org/browse/RA-1696). Kind regards…

---

<div class="post-metadata">

**Author:** ![reagan](https://talk.openmrs.org/user_avatar/talk.openmrs.org/reagan/32/10652_2.png) [@reagan](https://talk.openmrs.org/u/reagan)\
**Post date:** [February 2, 2020, 6:36pm UTC](https://talk.openmrs.org/t/missing-patientid/26552/13 "2020-02-02T18:36:59Z")

</div>

The fix works fine…Will send the PR when its made ready for work.

---

<div class="post-metadata">

**Author:** ![ruhanga](https://talk.openmrs.org/user_avatar/talk.openmrs.org/ruhanga/32/8318_2.png) [@ruhanga](https://talk.openmrs.org/u/ruhanga)\
**Post date:** [February 3, 2020, 6:55am UTC](https://talk.openmrs.org/t/missing-patientid/26552/14 "2020-02-03T06:55:21Z")

</div>

Thanks @reagan. @mozzy could you transition [RA-1696](https://issues.openmrs.org/browse/RA-1696) to ready for work? Thanks.

---

<div class="post-metadata">

**Author:** ![dkayiwa](https://talk.openmrs.org/user_avatar/talk.openmrs.org/dkayiwa/32/179_2.png) [@dkayiwa](https://talk.openmrs.org/u/dkayiwa)\
**Post date:** [February 3, 2020, 7:56am UTC](https://talk.openmrs.org/t/missing-patientid/26552/15 "2020-02-03T07:56:19Z")

</div>

@ruhanga i have just given you admin permissions to that JIRA project. So you should also be in position to do the needful. 🙂

---

<div class="post-metadata">

**Author:** ![ruhanga](https://talk.openmrs.org/user_avatar/talk.openmrs.org/ruhanga/32/8318_2.png) [@ruhanga](https://talk.openmrs.org/u/ruhanga)\
**Post date:** [February 3, 2020, 8:11am UTC](https://talk.openmrs.org/t/missing-patientid/26552/16 "2020-02-03T08:11:50Z")

</div>

Thanks @dkayiwa. @reagan I hope you can now get the pull request through. 🙂

---

<div class="post-metadata">

**Author:** ![ruhanga](https://talk.openmrs.org/user_avatar/talk.openmrs.org/ruhanga/32/8318_2.png) [@ruhanga](https://talk.openmrs.org/u/ruhanga)\
**Post date:** [February 28, 2020, 12:07pm UTC](https://talk.openmrs.org/t/missing-patientid/26552/17 "2020-02-28T12:07:08Z")

</div>

Thanks @reagan, I just merged the PR on [RA-1696](https://issues.openmrs.org/browse/RA-1696)

---

<div class="post-metadata">

**Author:** ![reagan](https://talk.openmrs.org/user_avatar/talk.openmrs.org/reagan/32/10652_2.png) [@reagan](https://talk.openmrs.org/u/reagan)\
**Post date:** [February 28, 2020, 12:40pm UTC](https://talk.openmrs.org/t/missing-patientid/26552/18 "2020-02-28T12:40:38Z")

</div>

Ur welcome @ruhanga

---

<div class="post-metadata">

**Author:** ![mozzy](https://talk.openmrs.org/user_avatar/talk.openmrs.org/mozzy/32/11815_2.png) [@mozzy](https://talk.openmrs.org/u/mozzy)\
**Post date:** [February 28, 2020, 2:32pm UTC](https://talk.openmrs.org/t/missing-patientid/26552/19 "2020-02-28T14:32:16Z")

</div>

@reagan deserves a dev2 badge for the geat work he as done in RA 😀

---

<div class="post-metadata">

**Author:** ![dkayiwa](https://talk.openmrs.org/user_avatar/talk.openmrs.org/dkayiwa/32/179_2.png) [@dkayiwa](https://talk.openmrs.org/u/dkayiwa)\
**Post date:** [February 29, 2020, 7:16pm UTC](https://talk.openmrs.org/t/missing-patientid/26552/20 "2020-02-29T19:16:06Z")

</div>

Can you initiate a talk post?

[Next page](https://talk.openmrs.org/t/missing-patientid/26552.md?page=2)
