metadatasharing module not working with core

Development
41

Thanks for the suggestion @gcliff. I actually tried 2.10 too but that was giving some other errors related to the changes in this PR, e.g., saying that it cannot find liquibase-update-to-latest-1.9.x.xml. But again I could find that file in the related jar, so I am guessing that it is another manifestation of the problem I am having with openmrs-servlet.xml when using 2.11.0-SNAPSHOT (which seems to be an issue in my environment only).

1 Like
42

Hello @bashir thanks for the feedback;

In this case it would be better to share the error logs as advised above using https://pastebin.com/ ,so that we can have a look at exactly where the problem is coming from in your environment set up and configurations

43

@bashir try this. Go to the directory from which you are running the sdk command and delete a folder named tomcat.8080. Then run the sdk again and see what happens.

1 Like
44

@dkayiwa - interesting. I’ve been noticing this tomcat.8080 directory lately and I don’t remember ever noticing it before the last few weeks. Is this new? Do you have any insights into this that you can share? Is this something we need?

1 Like
45

Thanks @dkayiwa this was exactly the problem. There is an openmrs-servlet.xml under tomcat.8080/work/Tomcat/localhost/openmrs/loader/ (left from an older SDK run) and I suppose Tomcat was reusing this one when resolving classpath:openmrs-servlet.xml.

Do you know why this directory is now being creating where the SDK is run? Looking at my older SDK environments, they have the same loader directory in their own SDK directory (i.e., under ~/openmrs/<SERVER_ID>) which seems reasonable. But the newer SDK server directories do not; instead tomcat.8080 is created where SDK command is run.

46

After doing some investigation, it is a problem which was introduced by this ticket: https://issues.openmrs.org/browse/SDK-193

I have committed a fix at: https://github.com/openmrs/openmrs-sdk/commit/1da7f45d5b0ba100b4c957187c500d2b0130d55f

And released a new version (3.13.6) of the sdk.

1 Like
47

Great; thanks for the quick fix @dkayiwa. I was actually curious what recent commit to the SDK code has introduced this regression and saw your fix in RunTomcat; that was fast :slight_smile: