locationAttributeTypes Page Returns “None” Despite Available Location Attribute Types (LegacyUI - Version 2.7.6 and Earlier)

Software
, ,
1

When accessing the locationAttributeTypes.list page via the Legacy UI module, the page returns a “None” response in the body, even though Location Attribute Types exist in the system. The issue appears not to be related to saving or persistence, as new attribute types can be successfully added. However, the list view fails to render any of the available entries.

Screenshot 2025-10-20 at 8.07.55 PM
Screenshot 2025-10-20 at 8.07.55 PM3456×1988 286 KB

Environment Details:

Steps to Reproduce:

  1. Navigate to OpenMRS - Home
  2. Log in with valid demo credentials.
  3. Go to: OpenMRS - Login
  4. Observe that the page displays "None" even when multiple Location Attribute Types are defined.

Expected Behavior:

The page should render a table listing all existing Location Attribute Types instead of displaying "None".

Actual Behavior:

The JSP page renders only the text "None" and does not list any of the available location attribute types.

Additional Notes:

  • Adding a new Location Attribute Type via the form works correctly — the data is saved and visible in the database.
  • The issue appears to be within the display logic or model binding on the JSP page (locationAttributeTypes.jsp), potentially around the data retrieval or iteration context at line 18.
  • This behavior is consistent across multiple versions of the LegacyUI module and OpenMRS platform releases.

References:

cc: @dkayiwa, @ibacher, @grace, @raff, @burke, @angshuonline, @mohant, @taseew

2

Thanks @rahu1ramesh for fully describing this. Do you wanna raise a pull request for it?

3

so seems this can only happen when this line returns false

4

Actually I am little confused. (Its been a really long time, I did anything with JSP and JSTL). If I debug

  • I can see that HTTP GET /openmrs/admin/locations/locationAttributeTypes.list - code execution coming to LocationAttributeTypeFormController.showForm() but it does not return any model. Maybe this is for old spring JSP form lifecycle method?
  • Actual return of the list of location attribute types happen LocationAttributeTypeListController.list() but the code execution never comes here.
  • I am wondering why is /admin/locations/locationAttributeTypes.list mapped to LocationAttributeTypeFormController? Maybe just a wrong URL mapping?
  • Right now LocationAttributeTypeListController is mapped to @RequestMapping("/admin/locations/locationAttributeTypes")
  • Strangely enough - hitting /openmrs/admin/locations/locationAttributeTypes - returns me a 404 error, although it has the right URL mapping

So I am wondering whats really happenning?

@dkayiwa @rahu1ramesh

5

I can confirm that it works if we do the right mapping. remove the /locationAttributeTypes.list mapping from the FormController and update the same in the ListController. (btw, the above is legacy ui version 1.22 and 1.23)

6

btw, any particular reason that 1.23 tag commit does not belong to any branch on the repo? (unlike say 1.22) Was it done from a fork outside of the repo or locally?

7

Also noticed that navigating to edit a concept attribute (same for location attribute) breaks the page.

/openmrs/admin/concepts/conceptAttributeType.form?id=1

However, the same seems to work with o3 demo. Both the cases, I am using legacy ui - 1.23 version, but we are using OMRS core 2.6.15

error thrown is:

openmrs-1  | WARN - AbstractHandlerExceptionResolver.logException(208) |2025-10-21T16:46:54,880| Resolved [org.springframework.web.method.annotation.MethodArgumentConversionNotSupportedException: Failed to convert value of type 'java.lang.String' to required type 'org.openmrs.ConceptAttributeType'; nested exception is java.lang.IllegalStateException: Cannot convert value of type 'java.lang.String' to required type 'org.openmrs.ConceptAttributeType': no matching editors or conversion strategy found]
8

1.23 has not yet been released openmrs-module-legacyui/pom.xml at 1.x · openmrs/openmrs-module-legacyui · GitHub

9

Thanks @dkayiwa. o3.openmrs.org seems to have 1.23.0 though. Also, the commit related to the 1.23 tag, has the version mentioned (not as snapshot). Check here

10

Should I just log an issue and raise a PR?

11

Oh yes, thanks! :+1:

12

I can’t seem to log an issue at issues.openmrs.org (routing to https://openmrs.atlassian.net/jira). Do I require an openmrs id? seemed to suggest so.

13

You log in JIRA with angshuonline@id.openmrs.org

Then on the next screen, you use the username of angshuonline and your openmrs id password.

1 Like
14

Created Issue on JIRA

PR associated with the story

@dkayiwa Can we also apply this on 1.22 or atleast 1.23? The main/master is for Platform version 2.7.* ++

Btw, on maven central I do see 1.23 released, but there is no associated commit in the repo. So, unsure about that.

15

Very nice catch :+1:

I have reviewed, merged, back ported to the 1.x branch and bumped its version to 1.24.0-SNAPSHOT

Thank you so much @angshuonline :slight_smile:

1 Like