IllegalStateException when running unit tests in rest module

gcliff · May 14, 2020, 2:43pm

Hello all;

Am adding a new version of the TaskAction resource for core 2.4.0, on running tests that i have added in the TaskActionController2_4Test class i get

java.lang.IllegalStateException: Two resources with the same name (v1/taskaction) must not have the same order

What does it mean for two resources not to have the same order?

full logs

@ibacher @dkayiwa

sidvaish97 · May 14, 2020, 3:12pm

@gcliff This might be of some use

gcliff · May 14, 2020, 4:07pm

thanks @sidvaish97 ,let me look into this

reagan · May 14, 2020, 4:11pm

@gcliff could u share a PR as well?

gcliff · May 14, 2020, 4:36pm

i have been able to fix the issue ,

i deactivated the parent resource’s support for platform version 2.4.0 and am good to go now

Thank you all

reagan · May 14, 2020, 6:28pm

Not sure I got u well…are u saying the parent had already implemented the TaskAction 2.4 resource already?

gcliff · May 14, 2020, 6:36pm

The parent was already supporting 2.4

github.com

openmrs/openmrs-module-webservices.rest/blob/85bca34919aa06ce631d18b08e1224fb4a9c5ab0/omod-1.8/src/main/java/org/openmrs/module/webservices/rest/web/v1_0/resource/openmrs1_8/TaskActionResource1_8.java#L41


import org.openmrs.module.webservices.rest.web.response.IllegalRequestException;
import org.openmrs.module.webservices.rest.web.response.ResourceDoesNotSupportOperationException;
import org.openmrs.module.webservices.rest.web.response.ResponseException;
import org.openmrs.scheduler.SchedulerException;
import org.openmrs.scheduler.TaskDefinition;


import java.util.ArrayList;
import java.util.Collection;


@Resource(name = RestConstants.VERSION_1 + "/taskaction", supportedClass = TaskAction.class, supportedOpenmrsVersions = {
        "1.8.*", "1.9.*", "1.10.*", "1.11.*", "1.12.*", "2.0.*", "2.1.*", "2.2.*", "2.3.*", "2.4.*" })
public class TaskActionResource1_8 extends BaseDelegatingResource<TaskAction> implements Creatable {
	
	private TaskServiceWrapper taskServiceWrapper = new TaskServiceWrapper();
	
	public void setTaskServiceWrapper(TaskServiceWrapper taskServiceWrapper) {
		this.taskServiceWrapper = taskServiceWrapper;
	}
	
	@Override
	public Object create(SimpleObject post, RequestContext context) throws ResponseException {