how to fix warning about bundledModules in openmrs-core

Development
,
1

Hello,

I am getting

WARN - Listener.loadBundledModules(500) |2018-02-21 07:54:59,103| Bundled module folder doesn’t exist: /Users/iulrich/code/openmrs/openmrs-core/webapp/src/main/webapp/WEB-INF/bundledModules

when running the current openmrs master branch, which points to a call of Listener.loadBundledModules(servletContext); trying to load modules which are bundled with openmrs-core at startup.

I think we deleted the folder when we removed modules from openmrs-core.

I could

  • add the src/main/webapp/WEB-INF/bundledModules back with a .gitkeep file in it, so the warning disappears and the logic remains the same
  • remove the call to Listener.loadBundledModules(servletContext); since we do not bundle modules

Let me know what you think and have a great day :slight_smile:

2

I thought we already bundle some modules with the platform. :smile:

I have also seen implementation distros like UgandaEMR which bundle modules in their war file. So removing this call would break them.

My proposal is to just remove the warning because the call is made, just in case there are any bundled modules to load. If there is none, no big deal. :slight_smile:

3

you are of course correct!

Just downloaded the latest openmrs.war 2.1.2 which comes with fhir, owa, webservices rest. So when running this one, the warning would not appear.

We could still add the src/main/webapp/WEB-INF/bundledModules back with a .gitkeep in openmrs-core since its needed in the end.

Is the platform bundled automatically for a release? Can you please point me to it, still so much to learn :slight_smile:

4

Are you looking for this? https://github.com/openmrs/openmrs-distro-platform :slight_smile: