How many required search parameters per resource

gayanw · May 19, 2017, 2:12pm

Can a resource have more than one required search parameter?

As following test asserts that withRequiredParameters() of a SearchQuery is never called twice, can a resource have more than one required search parameter?

github.com

openmrs/openmrs-module-webservices.rest/blob/96b9aefbebefcdb88cb74d49dd52322256f744f7/omod-1.9/src/test/java/org/openmrs/module/webservices/rest/web/v1_0/controller/openmrs1_9/ConceptController1_8Test.java#L318-L322


	@Test(expected = IllegalStateException.class)
	public void shouldThrowExceptionWhenSearchRequiredParametersAreCalledTwice() throws Exception {
		new SearchQuery.Builder("Some search description").withRequiredParameters("source").withRequiredParameters("name") // <- Exception
		        .withOptionalParameters("code").build();
	}

@teleivo @pascal

darius · May 19, 2017, 2:28pm

@gayanw, when you have >1 required parameters you’re supposed to do this:

.withRequiredParameters("p1", "p2", ...)

Not this:

.withRequiredParameters("p1").withRequiredParameters("p2")...

So yes, the code you’ve shared is doing what is intended. I have no idea why that test would be in ConceptController1_8Test, though. It belongs in SearchBuilderTest or something like that.

(If it were me I would have written the code a different way, to support multiple calls to requireParameter method that takes just one argument, but that’s personal preference.)