Help on resolving REPORT-806

dilantha · June 19, 2019, 2:26pm

Hi , I have fixed issue https://issues.openmrs.org/browse/REPORT-806 and raised a pull request to openmrs-module-reporting. Can someone review it please ?

Thanks

mksd · June 19, 2019, 2:39pm

@dilantha you can invite reviewers from GitHub btw:

Note that your PR is closed anyway.

mozzy · June 19, 2019, 3:01pm

added a comment to github , but your PR is closed. do you have a fresh PR ?

dilantha · June 19, 2019, 5:54pm

@mozzy @mksd https://github.com/openmrs/openmrs-module-reporting/pull/175 This is the correct PR. Also can you please tell me whom i should add as the reviewers ?

mozzy · June 19, 2019, 6:09pm

you can add @dkayiwa

dilantha · June 19, 2019, 6:15pm

@mozzy It does not allow me to add any reviewers : i cannot see that option

mozzy · June 19, 2019, 6:46pm

Thats true , for you to be able to add reviewers , you must have certain priviledges, and in openmrs ,its granted for dev3 and above i guess

mozzy · June 19, 2019, 6:46pm

can you update the ticket with the right PR ??

dilantha · June 19, 2019, 7:15pm

@mozzy Updated. Sorry i did not noticed that i have updated the jira with wrong pullrequest