GSoC 2020 : Upgrade Platform Core Libraries Project

Community GSoC
, ,
83

thank you very much for clarification . For this :

should i work on FHIR2 ? or it is not yet the moment.

84

Example remove out al these lines

and replace that with a single dependece on the test sub module of the OpenMRS core,

In that way , the sub-module will simply inherit the test libraries/dependencies defined in the coresponding OpenMRS core Version

1 Like
85

FHIR2 is still Work in progress as per say , @ibacher could direct you best where necesarry

2 Likes
86

and this line too from https://github.com/openmrs/openmrs-module-webservices.rest/blob/1b534e9b84272eeabe1357da5c3ca8ef4da8d5cb/pom.xml#L169 to https://github.com/openmrs/openmrs-module-webservices.rest/blob/1b534e9b84272eeabe1357da5c3ca8ef4da8d5cb/pom.xml#L187

1 Like
87

Sure , thats it

2 Likes
88

thanks @mozzy

2 Likes
89

Ensure all the Test libraries defined here in the OpenMRS core ,are not redefined in the Rest module Parent and Child POMs.

for example , you would also remove the depencies defined in the Child Poms like here in the child POM of sub-module 2.4 of the Rest Module

1 Like
90

@mozzy what about this https://issues.openmrs.org/browse/RESTWS-781 ?

91

Hello, I want to upgrade ca.uhn.hapi dependencies to 2.3 . I am getting this error https://pastebin.com/raw/vCdbxhm7

this is the PR https://github.com/openmrs/openmrs-core/pull/3227 thanks @dkayiwa @burke @teleivo

92

cc @dkayiwa

93

@achilep , can you paste the full error log ??

1 Like
94

error log https://pastebin.com/raw/NX1ZkRSL

95

The cause of the error In brief , the class MessageTypeRouter used here as a property was deprecated and replaced with ApplicationRouter

so it no longer exists in hapi 2.3.

that was just a pointer. youll need to do some refactoring in here

96

is what I have done https://github.com/openmrs/openmrs-core/pull/3227/commits/302fa591be5f157952e267bb2fbd7f5e1364e3f3#diff-ff1c6f2529d3db6f4d74910f2edeb13e before getting into this Error : https://pastebin.com/raw/NX1ZkRSL

97

oops , another point of cause of the error is in the applicationContext-service.xml

while setting bean property ‘router’

Spring still maps it to the deprecated class MessageTypeRouter , point it to the new class ApplicationRouter >> ca.uhn.hl7v2.protocol.ApplicationRouter

2 Likes
98

@achilep , i have seen you updated the router class in the applicationContext-service.xml , so the BeanCreationExceptions were solved.

But i can see you still have a few test failures below …you just simply need to update and fix the tests.

HL7ServiceTest.processHL7InQueue_shouldCreateHL7InArchiveAfterSuccessfulParsing:107 expected: <1> but was: <0>

4485[ERROR] ORUR01HandlerTest.processMessage_shouldFailIfQuestionDatatypeIsCodedAndABooleanIsNotAValidAnswer:707 Expected ca.uhn.hl7v2.app.ApplicationException to be thrown, but nothing was thrown.

4486[ERROR] ORUR01HandlerTest.processMessage_shouldFailIfQuestionDatatypeIsNeitherBooleanNorNumericNorCoded:724 Expected ca.uhn.hl7v2.app.ApplicationException to be thrown, but nothing was thrown.

4487[ERROR] ORUR01HandlerTest.processMessage_shouldFailIfTheProviderNameTypeCodeIsNotSpecifiedAndIsNotAPersonId:1092 Expected ca.uhn.hl7v2.app.ApplicationException to be thrown, but nothing was thrown.

4488[ERROR] ORUR01HandlerTest.processMessage_shouldFailOnEmptyConceptAnswers:426 Expected ca.uhn.hl7v2.app.ApplicationException to be thrown, but nothing was thrown.

4489[ERROR] ORUR01HandlerTest.processMessage_shouldFailOnEmptyConceptProposals:443 Expected ca.uhn.hl7v2.app.ApplicationException to be thrown, but nothing was thrown.

4490[ERROR] Errors:

4491[ERROR] HL7ServiceTest.processHL7Message_shouldSaveHl7MessageToTheDatabase:159 » HL7 E...
2 Likes