Gsoc 2019: Bootstrap as a foundation for Reference Application UI Project

Community GSoC
22

@ayesh Nope this project is not making structural changes to pages and existing components, it is focused on providing styling that can is based on a commonly used framework.

The existing legacy UI should not be affected

23

Sure thanks @ssmusoke can you let me know about the changes that I have done above for patient summary page and login page :slightly_smiling_face:

24

Where is the code for me to review?

25

Yeah thats true :smile:.Shall I create a PR and the thing is it has changes on multiple projects hope it’s ok @ssmusoke :slightly_smiling_face:

26

You can use https://issues.openmrs.org/browse/RA-1285 for the dashboard and create one for the login page.

Whatever tickets you will create will be tied to the epic https://issues.openmrs.org/browse/RA-1586 (which is the highest level ticket for this effort)

1 Like
27

Awesome thanks alot :crossed_fingers:

28

@ssmusoke @jwnasambu this is the Jira issue for the login page :-

And these are the PR with respective changes :

29

@ssmusoke @jwnasambu this is the Jira sub task for the patient summary page :-

And these are the PR changes :

30

Am just going though the changes you have made.

1 Like
31

Btw I think it will be good to have these changes on separate branches.Because integrating the bootstrap to the ref app is breaking the current styling in all pages.So have to fix them all and then should be pushed to the master branch.What do you think on this @ssmusoke and @jwnasambu.

32

@ayesh I do not understand what you mean. The changes are already on different branches in each module

33

You are right. Could this be of help?

34

No what I mean is till all changes done for the dashboard we must not merge these changes to the master.It’s good to keep all changes merged in to a new branch like bootstrap-integration and after doing changes to all pages are done then that branch can be pushed to master.Because with bootstrap integration styling breaks on all pages.

For example this is how the home page looks like now

Screenshot%20from%202019-05-13%2021-43-49
Screenshot%20from%202019-05-13%2021-43-491922×1076 76.9 KB

so until these changes are done we can’t merge it with master hope it make sens.

35

You are right. As you make changes keep in mind the objective and the CI build.

36

Yes @jwnasambu am always looking at coveralls and travis :crossed_fingers:

37

I suppose you made the changes on the master branch. Kindly create a branch make the changes and make a PR.

38

Hi @jwnasambu all chages are in branches as mentioned here but pointing to the master branch for the merge :slightly_smiling_face:

39

@ssmusoke had time to look at the code ? :slightly_smiling_face:

40

Will take a look tomorrow

41

Ok will work on the broken home page (because of the bootstrap integration) today :crossed_fingers: