Hi @ssmusoke @mozzy @herbert24
What is the status of the bug fixes Sorry I was out for Sri Lanka didnt get much time to involve. I still see some PR’s open can we merge them and complete the work I will start working on few left isues as well
2 Likes
@ayesh and @mozzy, this one is still current: Core Apps patient page look and feel different on desktop browsers
In short, the delete button is broken in view mode. Could you guys look into it?
1 Like
Hi @ayesh, have you had a chance to look into it? As in, the delete button in view mode, see here.
Also it seems that there is an issue with the obs across encounters dashboard widget that just overflows:
This happens on QA Ref App but not on the demo, hinting at Bootstrap again. It would be great if you could check that one out too.
You can reproduce the above on QA Ref App by adding here the app definition pasted below:
{
"id": "coreapps.obsAcrossEncounters.2",
"instanceOf": "coreapps.template.dashboardWidget",
"description": "foobar description",
"order": 1,
"config": {
"widget": "obsacrossencounters",
"icon": "icon-user-md",
"label": "foobar",
"concepts": "5242AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA, 5087AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA, 5088AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA, 5089AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA, 5090AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA",
"maxRecords": "5"
},
"extensions": [
{
"id": "org.openmrs.module.coreapps.mostRecentVitals.clinicianDashboardFirstColumn",
"appId": "coreapps.obsAcrossEncounters.2",
"extensionPointId": "patientDashboard.firstColumnFragments",
"extensionParams": {
"provider": "coreapps",
"fragment": "dashboardwidgets/dashboardWidget"
}
}
]
}
Cc @jesplana @ruhanga @mogoodrich
Btw, @mogoodrich and @ssmusoke, do you see those empty columns that are beeing added? I haven’t investigated that part yet but clearly that’s weird:
2 Likes
Here at PIH, we just deployed the latest coreapps SNAPSHOT to our test servers and the clinicianfacing dashboard now shows flat as just one column. I see at the top of this thread that this was one of the first issues you encountered. Can you please let us know what is the fix for this issue? I could not find the ticket and PR that indicates how you fixed this one column view. Thanks.
For the record I just tried on QA Ref App and the first issue that I described here above is solved.
The second one (the extra unwanted columns in the obs across encounters widget) not, @samuel34 will look into it, this is most likely not related to Bootstrap anyway.
I have tested out this from the QA server and issue persists, meaning it was possibly never fixed. The quoted below is the issue I’m talking about!
See demonstration below:
Do you see the overlay grey screen? It blocks user input hence disabling the ‘Delete’ operation.
Thank you @samuel34 for bringing up this problem again. Here, at PIH we are seeing the this problem in a few different pages. So far, the only major difference I could find between the clinicianfacing page, where the modal dialog works and the other pages where the modal is not working is that a newer jquery-3.4.1 library is included:
I suspect that there is a clash of so many different versions of the jquery library which are included from so many headers and pages across many modules.
2 Likes
So I was able to figure out what was going on with the modals, and I think I have a fix, I’m running it through our smoke tests now.
Basically, both “simplemodal” and Bootstrap extend JQuery objects with a “modal” function, and so with the introduction of bootstrap.js the simplemodal “modal” function was getting overwritten with the bootstrap “modal” function. Long-term, we likely want to fix the “setupConfirmationDialog” to work with the bootstrap modal and remove the simple modal entirely (https://issues.openmrs.org/browse/RA-1672) but I ticketed and merged my short-term fix here (https://issues.openmrs.org/browse/RA-1673).
A couple other questions:
-
We are still including JQuery 1.12.4 as part of the standard emr includes on every page (https://github.com/openmrs/openmrs-module-appui/blob/master/omod/src/main/webapp/fragments/standardEmrIncludes.gsp#L2) but then have begun to introduce JQuery 3.4.1 additionally on some pages well (https://github.com/openmrs/openmrs-module-coreapps/blob/master/omod/src/main/webapp/pages/clinicianfacing/patient.gsp#L5). This seems ripe for conflict. Should we consider just upgrading to 3.4.1 (realizing that this may be a nontrivial amount of testing/fixing)?
-
Is there a particular reason we are including Bootstrap in standardEmrPage (https://github.com/openmrs/openmrs-module-appui/blob/master/omod/src/main/webapp/fragments/decorator/standardEmrPage.gsp#L5) and not standardEmrIncludes (https://github.com/openmrs/openmrs-module-appui/blob/master/omod/src/main/webapp/fragments/standardEmrIncludes.gsp)?
Take care, Mark
1 Like
Thanks @mogoodrich for the research, and I think this was the issue all over the place, due to different JQuery and Boostrap versions.
My suggestion is that we nuke the JQuery 1.12.4 then fix whatever breakages it creates
Thanks @mogoodrich for that research and fix.
@samuel34 can you test again and confirm that fix works ??
I tested it on the qa-server , it now works ,that is ,the form form gets deleted, However after clicking the delete button , theres no any UI response ie the dialogue box doesnt disapper , or nothing thing like a message to show that the form is deleted.
@ssmusoke I agree re: nuking JQuery 1.12.4 but it’s unclear what amount of cleanup will be needed… there’s also unfortunately the fact that it could likely affect distro-specific pages. What’s the timeframe for doing the next reference app release? I would actually like to cut a release of at lease appui, uicommons and coreapps before making that change, so we at least have something semi-stable before making that change.
We are looking to do a release of the PIH EMR in the next week or two, and so will be embarking on a full regression test shortly, will let you know how that goes (and how it goes may affect my decisions on the next step forward).
@mozzy I will try to test on the qa-server as well and see what I find.
Take care, Mark
@mogoodrich , ideally we would have had this release last year , but it was lengthened by the Ui breakages due to Bootsrap intergration . However we can still hold the release till we fix all the UI breakages.
Thanks @mozzy… my thought would be if the duplicate JQuery is not causing any immediate problems, we do a release as-is, and then tackle upgrading JQuery fully for the next release. However, if regression testing ends up showing that it’s currently causing problems to have both versions of JQuery present I’d likely revise my thoughts.
2 Likes