cannot access PatientCalculationContext error

ivange94 · October 30, 2018, 7:45am

When I call EvaluationService.evaluate(queryBuilder, context), InteliJ gives me an error that cannot access org.openmrs.calculation.patient.PatientCalculationContext.

I also noticed that even lines like

sqlQueryBuilder sqlQueryBuilder = new SqlQueryBuilder();
String sqlQuery = "select o.person_id from obs o  inner join patient p on o.person_id = p.patient_id  "
                + "where o.voided = false and p.voided = false  and concept_id = :questionConceptId  and "
                + "o.obs_datetime >= :onOrAfter  and o.obs_datetime <= :onOrBefore  and  o.value_coded IN (:valueList)";
sqlQueryBuilder.append(sqlQuery);
sqlQueryBuilder.setParameters(context.getParameterValues());

that don’t show this error in InteliJ fails during build with the same error message.

mksd · October 30, 2018, 9:01am

Just to clear it out, the errors that you see can also be seen from Maven CLI right?

Can you give me more info as to how to reproduce this?

ivange94 · October 30, 2018, 9:08am

Yes.

If you use InteliJ, calling

EvaluationService.evaluateToList(sqlQueryBuilder, context)

any where in the code will show an error messages. Though this doesn’t prevent the code from building. But having

SqlQueryBuilder sqlQueryBuilder = new SqlQueryBuilder();
String sqlQuery = "select o.person_id from obs o  inner join patient p on o.person_id = p.patient_id  "
                + "where o.voided = false and p.voided = false  and concept_id = :questionConceptId  and "
                + "o.obs_datetime >= :onOrAfter  and o.obs_datetime <= :onOrBefore  and  o.value_coded IN (:valueList)";
sqlQueryBuilder.append(sqlQuery);
sqlQueryBuilder.setParameters(context.getParameterValues());

Will cause the build to fail with a compile error on the last line. Though this isn’t reported by InteliJ but the error message is the same as that reported by InteliJ when you call

EvaluationService.evaluateToList(sqlQueryBuilder, context)

mksd · October 30, 2018, 10:23am

Can you point me to a branch that I can clone to look into this?

ivange94 · October 30, 2018, 11:04am

Here you go

github.com

ivange94/openmrs-module-mksreports/blob/test/api/src/main/java/org/openmrs/module/mksreports/reports/OutpatientConsultationReportManager.java#L324-L335


	public void test() {
		EvaluationService evaluationService = Context.getService(EvaluationService.class);
		String QUERY = "select o.person_id from obs o  inner join patient p on o.person_id = p.patient_id "
		        + " where o.voided = false and p.voided = false";
		EvaluationContext context = new EvaluationContext();
		context.addParameterValue("startDate", DateUtil.parseDate("2008-08-01", "yyyy-MM-dd"));
		context.addParameterValue("endDate", DateUtil.parseDate("2009-09-30", "yyyy-MM-dd"));
		SqlQueryBuilder queryBuilder = new SqlQueryBuilder();
		queryBuilder.append(QUERY);
		queryBuilder.setParameters(context.getParameterValues());
		List<Object[]> result = evaluationService.evaluateToList(queryBuilder, context);
	}

When trying to reproduce this, I noticed those exact same lines of codes don’t throw any error or cause the build to fail when placed inside a unit test.

mseaton · October 30, 2018, 1:35pm

@ivange94, the issue appears to be that you are including the dependency of calculation-api with a “test” scope. I think you’ll find that if you change that to “provided”, then things will start to work as expected. Provided scope is appropriate because the calculation module is a runtime dependency that is required to be available (based on the fact that it is required by the reporting module).

Mike

ivange94 · October 30, 2018, 2:36pm

@mseaton you’re right. Changing the scope to provided made the error disappear. Thanks.