Bug: Translation Key incorrect on Consultation Tab

Hi all,

This is a bug in Bahmni 0.91 and 0.92.

When the user enters the diagnosis of a patient on the diagnosis tab, the diagnosis information contains a label named “Revised” which displays the translation key instead of this label on the consultation tab of the Clinical module.

Steps to reproduce:

Scenario 1: In this scenario, the patient has added the diagnosis on the diagnosis tab and the Revised label is getting displayed as the translation key “CONSULTATION_TAB_REVISED_DIAGNOSIS_LABEL_DIAGNOSIS_LABEL”

Once this consultation is saved, the label is visible as “Revised”

TRANSLATION KEY VISIBLE BEFORE SAVING THE CONSULTATION

TRANSLATION KEY NOT VISIBLE AFTER SAVING THE CONSULTATION

Please take a note that the key visible here is “CONSULTATION_TAB_REVISED_DIAGNOSIS_LABEL_DIAGNOSIS_LABEL” which is incorrectly mentioned.

Scenario 2: On adding the translation key on the i18 folder of the Clinical module, the Revised label is properly visible before the consultation is saved but after the save of the consultation, the label is displaying the key “CONSULTATION_TAB_REVISED_DIAGNOSIS_LABEL” which is the vice versa of the previous scenario mentioned and the key is also different.

TRANSLATION KEY NOT VISIBLE BEFORE SAVING THE CONSULTATION

TRANSLATION KEY VISIBLE AFTER SAVING THE CONSULTATION

The above mentioned behaviour according to the scenarios are happening on the 0.92 version of Bahmni.

Findings:

On investigation, the html file “consultation.html” (path) contains the label “CONSULTATION_TAB_REVISED_DIAGNOSIS_LABEL_DIAGNOSIS_LABEL” in only one particular place and the rest of the file has “CONSULTATION_TAB_REVISED_DIAGNOSIS_LABEL” key and the i18n folder contains the label “CONSULTATION_TAB_REVISED_DIAGNOSIS_LABEL” for displaying the label “Revised”

Suggested approach to fix the bug:

As a contribution to the community, we would like to raise a PR for this small fix by changing the translation key from “CONSULTATION_TAB_REVISED_DIAGNOSIS_LABEL_DIAGNOSIS_LABEL” to “CONSULTATION_TAB_REVISED_DIAGNOSIS_LABEL” on the html file “consultation.html”

Kindly raise a JIRA card for this issue against the product. Then raise a PR mentioning the JIRA card.

Can you share the JIRA card number and the pull request?

@buvaneswariarun

JIRA card number : BAH-1057

PR : https://github.com/Bahmni/openmrs-module-bahmniapps/pull/299

1 Like