# asking for review. all checks passed

**URL:** <https://talk.openmrs.org/t/asking-for-review-all-checks-passed/45576>\
**Category:** Uncategorized\
**Created:** [March 28, 2025, 4:13pm UTC](https://talk.openmrs.org/t/asking-for-review-all-checks-passed/45576 "2025-03-28T16:13:03Z")\
**Posts on this page:** 1\
**Page:** 1

<div class="post-metadata">

**Author:** ![snow](https://talk.openmrs.org/user_avatar/talk.openmrs.org/snow/32/20196_2.png) [@snow](https://talk.openmrs.org/u/snow)\
**Post date:** [March 28, 2025, 4:13pm UTC](https://talk.openmrs.org/t/asking-for-review-all-checks-passed/45576/1 "2025-03-28T16:13:03Z")

</div>

![Screenshot from 2025-03-28 19-10-13](https://talk.openmrs.org/uploads/default/original/3X/f/6/f609588e152406865ea554cfccd11c40de4b7eef.png)i asked for a review in comment two days back. but no one has did it. and its going to weekend. and no the sight are muted. i ant change them. view the screenshot to see what am meaning. thank you

> <https://github.com/openmrs/openmrs-core/pull/4983>
>
> TRUNK-4988: Refactor MessageService to Use Spring Dependency Injection
> 
> \## Des…cription of what I changed
> Implemented the configureMessageService(MessageSender, MessagePreparator) method to configure MessageService using Spring’s Dependency Injection.
> 
> Updated getMessageService() to rely on Spring DI and removed the manual setting of dependencies.
> 
> Refactored MessageService initialization for cleaner, more maintainable code that follows DI principles.
> 
> Added a unit test to verify that the configureMessageService() method works as expected.
> 
> \## Issue I worked on
> 
> 
> 
> 
> see \[This\](https://openmrs.atlassian.net/browse/TRUNK-4988)
> 
> \## Checklist: I completed these to help reviewers :)
> 
> 
> \- \[x\] My IDE is configured to follow the \[\*\*code style\*\*\](https://wiki.openmrs.org/display/docs/Java+Conventions) of this project.
> \- \[x\] I have \*\*added tests\*\* to cover my changes. (If you refactored
> existing code that was well tested you do not have to add tests)
> \- \[x\] I ran \`mvn clean package\` right before creating this pull request and
> added all formatting changes to my commit.
> 
> \- \[x\] All new and existing \*\*tests passed\*\*.
> \- \[x\] My pull request is \*\*based on the latest changes\*\* of the master branch.
> 
> No? Unsure? -\> execute command \`git pull --rebase upstream master\`
> !\[Screenshot from 2025-03-26 21-23-56\](https://github.com/user-attachments/assets/a3000bd4-32d9-4633-883d-d2da18ff1b41)